Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sk/doc dir sync #596

Open
wants to merge 9 commits into
base: sk/joss-publication
Choose a base branch
from
Open

Sk/doc dir sync #596

wants to merge 9 commits into from

Conversation

skeating
Copy link

Description

Fixes #{issue_number}: A few words or sentences describing the changes proposed in this pull request (PR).

Type of change

Please delete options accordingly to the description.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Suggested Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have passed on my local host device. (see further details at the CONTRIBUTING document)
  • Make sure your branch is up-to-date with main branch. See CONTRIBUTING for a general example to syncronise your branch with the main branch.
  • I have requested review to this PR.
  • I have addressed and marked as resolved all the review comments in my PR.
  • Finally, I have selected squash and merge

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 93.93939% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.64%. Comparing base (4af6ed0) to head (26b6e2d).
Report is 25 commits behind head on sk/joss-publication.

Files with missing lines Patch % Lines
pixl_dcmd/src/pixl_dcmd/main.py 88.88% 4 Missing ⚠️
..._core/src/core/project_config/pixl_config_model.py 92.00% 2 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           sk/joss-publication     #596      +/-   ##
=======================================================
+ Coverage                87.51%   87.64%   +0.12%     
=======================================================
  Files                       76       76              
  Lines                     3437     3512      +75     
=======================================================
+ Hits                      3008     3078      +70     
- Misses                     429      434       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomaroberts tomaroberts changed the base branch from sk/joss-publication to main March 4, 2025 10:33
@tomaroberts tomaroberts changed the base branch from main to sk/joss-pub March 4, 2025 10:33
@tomaroberts tomaroberts changed the base branch from sk/joss-pub to sk/joss-publication March 4, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant