Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Restore event suspension #203

Merged
merged 1 commit into from
May 3, 2019
Merged

Conversation

AmaranthineCodices
Copy link
Contributor

@AmaranthineCodices AmaranthineCodices commented May 3, 2019

Restores event suspension, which was removed by setState suspension (#183). We're reintroducing this behavior because events can fire while updating properties, which allows you to observe the Roblox instance in an intermediate state that you probably don't want to be doing any calculations on.

@AmaranthineCodices AmaranthineCodices changed the title Restored event suspension Restore event suspension May 3, 2019
Copy link
Contributor

@ZoteTheMighty ZoteTheMighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I've seen this before...

LGTM!

Copy link
Contributor

@LPGhatguy LPGhatguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks very familiar!

@LPGhatguy LPGhatguy merged commit ebfe578 into new-reconciler May 3, 2019
@LPGhatguy LPGhatguy deleted the resurrect-event-suspension branch May 3, 2019 23:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants