Update terminology in documentation #193

ZoteTheMighty · 2019-04-26T21:25:39Z

Remove references to primitive components/elements and use host as the descriptor
Similarly, we should change functional component -> function component
Update some links that appear to be broken???

Checklist before submitting:

~~Added entry to CHANGELOG.md~~
~~Added/updated relevant tests~~
Added/updated documentation

docs/performance/reduce-reconciliation.md

) * Deprecate Roact.reconcile in favor of Roact.update * Update CHANGELOG

…#195) * Remove undocumented APIs * Update CHANGELOG

… to update. Occasional mentions of 'the Roact reconciler' have been changed to simply 'Roact'

… element tracebacks

docs/api-reference.md

docs/guide/state-and-lifecycle.md

lib/Component.lua

GetPropertyChangedSignal does not pass the new value of the property to the function and the Roact.Change handler doesn't add this functionality so the current example code is slightly misleading.

…pet for enabling it to docs

LPGhatguy and others added 2 commits April 24, 2019 21:51

Add rotriever.toml

f1843c1

Remove references to 'primitive' components/elements

ff5ba4d

ZoteTheMighty changed the title ~~Remove references to 'primitive' components/elements~~ Update terminology in documentation Apr 26, 2019

ZoteTheMighty added 2 commits April 26, 2019 15:04

Adjust some wording around kinds of components, fix broken link

eacba5d

functional component -> function component

4065f72

LPGhatguy reviewed Apr 26, 2019

View reviewed changes

docs/performance/reduce-reconciliation.md Outdated Show resolved Hide resolved

ZoteTheMighty added 2 commits April 26, 2019 15:48

Dunno what happened with these links, but I've fixed them all

60ab920

Avoid usage of the verb 'reconcile' where not directly applicable

bfff354

LPGhatguy mentioned this pull request Apr 26, 2019

Deprecate Roact.reconcile in favor of Roact.update in master #194

Merged

2 tasks

LPGhatguy and others added 6 commits April 26, 2019 17:45

Deprecate Roact.reconcile in favor of Roact.update in master (Roblox#194

462ecf7

) * Deprecate Roact.reconcile in favor of Roact.update * Update CHANGELOG

Remove undocumented APIs getGlobalConfigValue and Element (Roblox…

fdf4d39

…#195) * Remove undocumented APIs * Update CHANGELOG

Roact.reconcile replaced with Roact.update, uses of reconcile changed…

7aff307

… to update. Occasional mentions of 'the Roact reconciler' have been changed to simply 'Roact'

Add version info to new apis; add entry for

69db90a

Added more details to validateProps, added section for setGlobalConfig

cf9c5e3

Added the 'enable tracebacks' message to other places that try to use…

ada7566

… element tracebacks

ZoteTheMighty marked this pull request as ready for review May 2, 2019 01:14

ZoteTheMighty added the new reconciler label May 2, 2019

LPGhatguy suggested changes May 2, 2019

View reviewed changes

DarraghGriffin and others added 5 commits May 2, 2019 10:57

Change misleading code in Roact.Change example (Roblox#196)

4a8b70f

GetPropertyChangedSignal does not pass the new value of the property to the function and the Roact.Change handler doesn't add this functionality so the current example code is slightly misleading.

PR comments: mention deprecated names, fix links

cdd7388

Revert change to getElementTraceback

ea20987

Rename propertyValidation config key to propValidation, add code snip…

b369dc8

…pet for enabling it to docs

Merge branch 'master' into primitive-to-host

d948b70

ZoteTheMighty force-pushed the primitive-to-host branch from 70861b1 to d948b70 Compare May 2, 2019 18:35

ZoteTheMighty requested a review from LPGhatguy May 2, 2019 20:23

LPGhatguy approved these changes May 3, 2019

View reviewed changes

ZoteTheMighty merged commit 2acd7bd into Roblox:new-reconciler May 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update terminology in documentation #193

Update terminology in documentation #193

ZoteTheMighty commented Apr 26, 2019 •

edited

Loading

Update terminology in documentation #193

Update terminology in documentation #193

Conversation

ZoteTheMighty commented Apr 26, 2019 • edited Loading

ZoteTheMighty commented Apr 26, 2019 •

edited

Loading