add default resolver for regtest #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicbus
force-pushed
the
regtest_default_resolver
branch
from
9509d2c to
6a517d3
Compare
nicbus
force-pushed
the
regtest_default_resolver
branch
from
6a517d3 to
b4d806c
Compare
|
@dr-orlovsky I added a commit to have GH build action pass with default and electrum features not sure this is the correct approach, let me know if it needs to be addressed in a different way |
dr-orlovsky
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
ACK b4d806c
I think adding default options is a good idea, since most of software using the rgb as library would default to electrum and would need logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this small PR adds a default electrum resolver for the
Regtestnetwork in thedefault_resolverfunction