-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add set-host command #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some style improvements - otherwise LGTM. Why draft?
5cbe900
to
733d074
Compare
great, updated
This PR was set as draft since it could not work until note: I now introduced a commit that updates |
added a commit to update an outdated github action (actually to re-trigger CI as it failed for an internal error on the previous run) it still failed, though, with more internal errors the PR IMO is ready, the only test that failed in the previous run (build/cli) succeeds locally ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK with nits. If you want, I can merge it as is; but if you prefer to address nits, this is also an option
7aae7fe
to
2237967
Compare
liked the suggestions, updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2237967
Very cool, thank you!
This PR adds the
set-host
command to setopret
/tapret
host, if needed.This is intended to be called by a user that has prepared a PSBT with an output ready for the commitment but needing to set it as a host, via CLI.
This comes from (and depends on) rgb-wallet PR #46, which initially did the same in the
pay
command but now only makesopret
andtapret
modules public.