Fix deepcopy/pickle of DAGCircuit variable IO nodes
#14041
Merged
+81
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were accidentally using NodeType::VarIn when extracting DAGOutNode.
|
One or more of the following people are relevant to this code:
|
kevinhartman
added
Changelog: Bugfix
Pull Request Test Coverage Report for Build 13909797891Details
💛 - Coveralls |
|
@Mergifyio backport stable/1.4 |
✅ Backports have been created
|
ElePT
approved these changes
Mar 18, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
* Fix var DAGOutNode bug in DAGCircuit::pack_into. We were accidentally using NodeType::VarIn when extracting DAGOutNode. * Add release note since this is pre 2.0.0. (cherry picked from commit ddd0401) # Conflicts: # crates/circuit/src/dag_circuit.rs
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
* Fix var DAGOutNode bug in DAGCircuit::pack_into. We were accidentally using NodeType::VarIn when extracting DAGOutNode. * Add release note since this is pre 2.0.0. (cherry picked from commit ddd0401) # Conflicts: # crates/circuit/src/dag_circuit.rs
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
… (#14043) * Fix deepcopy/pickle of `DAGCircuit` variable IO nodes (#14041) * Fix var DAGOutNode bug in DAGCircuit::pack_into. We were accidentally using NodeType::VarIn when extracting DAGOutNode. * Add release note since this is pre 2.0.0. (cherry picked from commit ddd0401) # Conflicts: # crates/circuit/src/dag_circuit.rs * Fix conflict --------- Co-authored-by: Kevin Hartman <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
… (#14044) * Fix deepcopy/pickle of `DAGCircuit` variable IO nodes (#14041) * Fix var DAGOutNode bug in DAGCircuit::pack_into. We were accidentally using NodeType::VarIn when extracting DAGOutNode. * Add release note since this is pre 2.0.0. (cherry picked from commit ddd0401) # Conflicts: # crates/circuit/src/dag_circuit.rs * Update dag_circuit.rs * Update crates/circuit/src/dag_circuit.rs --------- Co-authored-by: Kevin Hartman <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a typo we've had for a while in
DAGCircuit::pack_intothat would causeVaroutput nodes to become input nodes duringdeepcopyor pickling.Details and comments
The
DAGCircuit::pack_intomethod is only called with IO nodes from withinDAGCircuit::__setstate__, so this bug would only trigger for deep-copied or un-pickled DAGs with variables.