Make Target use interners to store gate names
#14040
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix trait bounds in certain methods of `Interner` to allow use of elements that satisfy the trait bounds of `Equivalent<T>` in `IndexMap`.
raynelfss
added
on hold
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13931428842Details
💛 - Coveralls |
raynelfss
changed the title
Target use interners to store gate names
- The `Target` usually keeps up to 5 copies of the names of every gate instance, this is due to the many mappings present within that still need to keep a connection betwen the gate name and some other relation or attribute. By using interners, we ensure that we only keep one instance of each gate's name and we use indices to satisfy the correlation later on. - Make the `_gate_name_map` attribute private to rust, use the available api as an alternative. - These changes are internal and should not affect how the target is used throughout our infrastructure.
raynelfss
force-pushed
the
target-use-interners
branch
from
00efffa to
1861247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is built on top of #14039, and should not be merged before it. The following commits aim to add usage of interners for the gate names in the
Target.Details and comments
This PR is built on top of #14039, and should not be merged before it. The
Targetcurrently keeps up to 5 copies of the names of every gate instance, this is due to the many mappings present within that still need to keep a connection between the gate name and some other relation or attribute. By using interners, we ensure that we only keep one instance of each gate's name and we use indices to satisfy the correlation later on.These changes are internal and should not affect how the target is used throughout our infrastructure.