Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor docs follow-up to #12850 #14012

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Mar 13, 2025

Summary

This PR applies the docs review comments from #12850.

Details and comments

@ElePT ElePT requested a review from a team as a code owner March 13, 2025 12:12
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@ElePT ElePT added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Mar 13, 2025
@ElePT ElePT added this to the 2.0.0 milestone Mar 13, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13834294464

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+1.6%) to 89.76%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 94.69%
crates/qasm2/src/expr.rs 1 94.23%
crates/qasm2/src/lex.rs 3 91.48%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 13831282993: 1.6%
Covered Lines: 46492
Relevant Lines: 51796

💛 - Coveralls

@@ -226,7 +226,7 @@ def generate_preset_pass_manager(
raise ValueError(
f"Gates with 3 or more qubits ({gate}) in `basis_gates` or `backend` are "
"incompatible with a custom `coupling_map`. To include 3-qubit or larger "
" gates in the transpilation basis, use a custom `target` instance instead."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't lowercase more correct to use here since that refers to the input argument? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants