Use OnceLock to cache a NormalOperation in Target
#13995
+190
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As we plan to use `PackedOperation` to add instructions to a `Target` in Rust. We should not require having a python instance exists within. The following commits fix that by ensuring that a python instruction is not required, and if so it can be built based on a `PackedOperation`'s internal data. - This should not have any visible effects on the current implementations, but can be proven to work via the added unit-tests.
|
One or more of the following people are relevant to this code:
|
raynelfss
changed the title
OnceLock to cache a NormalOperation in TargetOnceLock to cache a NormalOperation in Target
raynelfss
added
Changelog: None
Pull Request Test Coverage Report for Build 13795835470Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following commits replace the
op_objectattribute ofNormalOperationwith aOnceLockto allow the python version to be either built dynamically or cached from its original source.Details and comments
As we plan to use
PackedOperationto add instructions to aTargetin Rust. We should not require having a python instance to exist within. The following commits fix that by ensuring that a python instruction is not required, and if so it can be built based on aPackedOperation's internal data.This should not have any visible effects on the current implementations, but can be proven to work via the added unit-tests.