Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History dialog: focus third (second) item on show #209

Closed
ProgerXP opened this issue Jan 12, 2019 · 4 comments
Closed

History dialog: focus third (second) item on show #209

ProgerXP opened this issue Jan 12, 2019 · 4 comments
Assignees

Comments

@ProgerXP
Copy link
Owner

Make it so that when Alt+H dialog appears, the list of files is focused and the second item from top (i.e. target for Alt+G) is focused. Thus pressing Up/Down arrow keys changes selection in the list without the need to click inside the list with the mouse to focus it.

If the list has fewer entries than 2 (1 or 0) then do whatever is easier to implement (e.g. don't focus at all, or focus 1st item).

@cshnik
Copy link
Collaborator

cshnik commented Jan 14, 2019

Done.

  1. First item is selected when current document is untitled or history size < 2.
  2. Second item is selected when document is not untitled.
  3. Fixed n2e_OpenMRULast()-method (handles Alt+G command): recent files were not swapped.

@cshnik cshnik assigned ProgerXP and unassigned cshnik Jan 14, 2019
@ProgerXP
Copy link
Owner Author

Good addition.

@ProgerXP
Copy link
Owner Author

ProgerXP commented Sep 8, 2021

Add 1 to the focused item's index so that History focuses the item immediately following the one subject to Recall (#8). Currently it focuses exactly the Recall item. This way, Alt+G opens previously opened file and Alt+H,Enter opens the file that was opened before the previously opened file.

@ProgerXP ProgerXP reopened this Sep 8, 2021
@ProgerXP ProgerXP assigned cshnik and unassigned ProgerXP Sep 8, 2021
@ProgerXP ProgerXP changed the title History dialog: focus second item on show History dialog: focus third (second) item on show Sep 8, 2021
@cshnik
Copy link
Collaborator

cshnik commented Aug 1, 2022

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants