Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(process_manager/local): user id param #279

Closed
wants to merge 1 commit into from
Closed

fix(process_manager/local): user id param #279

wants to merge 1 commit into from

Conversation

stakach
Copy link
Member

@stakach stakach commented Jan 12, 2025

malformed when executed via webhooks as space not properly encoded\

@stakach
fix(process_manager/local): user id param
efcb6c0 
malformed when executed via webhooks as space not properly encoded
@stakach stakach requested a review from naqvis January 12, 2025 22:05
@github-actions github-actions bot added the type: bug something isn't working label Jan 12, 2025
@stakach
Copy link
Member Author

stakach commented Jan 12, 2025

NOTE:: the crystal-style failure here is due to differences between crystal 14 and 15 so can be ignored

@stakach
Copy link
Member Author

stakach commented Jan 12, 2025

closing as fixed in rest api PlaceOS/rest-api@0d8f5b8
and would prefer to keep the performance of using strings directly

@stakach stakach closed this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naqvis naqvis Awaiting requested review from naqvis

Assignees

@stakach stakach

Labels
type: bug something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stakach