Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/creole tests #690

Merged
merged 11 commits into from
Apr 26, 2020
Merged

Feature/creole tests #690

merged 11 commits into from
Apr 26, 2020

Conversation

efalkner
Copy link
Collaborator

Linked issues:

#689
#677
#522

Screenshots:

These are generated by CI via the tests running.

How to test

Run end to end tests locally or in CI. Expect each test to run against English and Haitian Creole localized app.

tstirrat
tstirrat previously approved these changes Apr 26, 2020
View reviewed changes
Copy link
Contributor

@tstirrat tstirrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

tstirrat
tstirrat previously approved these changes Apr 26, 2020
View reviewed changes
This was linked to issues Apr 26, 2020
In Haitian Creole, some of the Exposure Data screen is still in English #677
Closed
Add End to End tests for Haitian Creole on iOS #689
Closed
@summetj
Copy link
Collaborator

summetj commented Apr 26, 2020 •
edited
Loading

@efalkner FYI - If you want to "auto-link" the issues to this PR, you must have the keyword (fixes/closes) in front of each issue number separately, so you need to say:
fixes #689
fixes #677
instead of just listing the numbers.
(I went ahead and manually linked those two issues in the sidebar for you).

@efalkner
Copy link
Collaborator Author

Thanks @summetj . This really is only related to one of the issues (and encapsulates the other issue). I'm not sure if we have a way to auto link using 'relates to', but that would be useful, I think

@efalkner efalkner merged commit a0aaeaf into Path-Check:develop Apr 26, 2020
@efalkner efalkner deleted the feature/creole_tests branch April 26, 2020 21:07
@summetj summetj removed a link to an issue Apr 26, 2020
In Haitian Creole, some of the Exposure Data screen is still in English #677
Closed
@summetj
Copy link
Collaborator

summetj commented Apr 26, 2020

Thanks @summetj . This really is only related to one of the issues (and encapsulates the other issue). I'm not sure if we have a way to auto link using 'relates to', but that would be useful, I think

Got it, I've removed #677 from the linked issues so that only #689 will be auto-closed when this is merged.

tstirrat added a commit that referenced this pull request Apr 26, 2020
@tstirrat
Merge branch 'develop' into ts-eslint-errors
6151f74 
* develop:
  Make nav back arrow color theme aware (#686)
  yarn run-ios now runs pod install (#681)
  Fix settings icon on iOS 12, replace with new icon (#687)
  Feature/creole tests (#690)
tstirrat added a commit that referenced this pull request Apr 27, 2020
@tstirrat
Merge branch 'develop' into ts-cleanup-english-strings
a0ce2b3 
* develop:
  Auto add authorities (#587)
  Clean up more eslint issues (#678)
  Make nav back arrow color theme aware (#686)
  yarn run-ios now runs pod install (#681)
  Fix settings icon on iOS 12, replace with new icon (#687)
  Feature/creole tests (#690)
tstirrat added a commit that referenced this pull request Apr 28, 2020
@tstirrat
Merge branch 'develop' into ts-i18n-pull-script
5e573e2 
* develop:
  Fix "plural" keys, add i18n checks for new PRs (#648)
  Auto add authorities (#587)
  Clean up more eslint issues (#678)
  Make nav back arrow color theme aware (#686)
  yarn run-ios now runs pod install (#681)
  Fix settings icon on iOS 12, replace with new icon (#687)
  Feature/creole tests (#690)
  Fix formatting EULAs (#671)
  [i18n] Don't translate terms_of_use_url (#642)
  Fix background to run to edge of screen on iOS (#682)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstirrat tstirrat tstirrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add End to End tests for Haitian Creole on iOS
3 participants
@efalkner @summetj @tstirrat