-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Limit engine for Wifi module. #535
Conversation
new /limit API endpoint Added classes: Limit LimitProperties LimitType class POST { "type": type, "value": value, "auto_release" : optional bool } type actually possible are : 'time", "energy", "soc", "range" only time & energy are implemented. Disable state when time or energy session > defined limit. Release disable claim when car is disconnected. time_limit in minutes session_energy in w/h
Seems we are good for review now |
Mhh not ready to merge, something I've changed crash the fw. Will check tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some great work. Just a few changes and I think this will work well
All changes done, seems we are good to go. I think of a first selector for the Type, then a conditionned input ( time input for time, selector/ or number input for energy, slider for soc, selector/number input for range |
@jeremypoulter , I've finished to setup the UI2 for those new limits. Ready to push it when this is merged. |
Mid reviewing/testing, hopefully a day or two |
I've pushed the gui limit branch here, if you want to test with : https://github.com/KipK/openevse-gui-v2/tree/Limit |
Added default limits at boot ( UI undone ) Default limit set from /config have auto_release set to false add "limit_version" event
I"ve added new settings in the /config , it allows to set a permanent limit. On the UI side I'll place it in the configuration section, to differentiate from limits from the main charging page. |
thx UI merged to master. |
Limit engine for Wifi module. Replace limits from OpenEvse module.
New /limit API endpoint
Added classes:
Limit
LimitProperties
LimitType class
POST { "type": type, "value": value, "auto_release" : optional bool }
type actually possible are : 'time", "energy", "soc", "range"
Disable state when time or energy session > defined limit.
Release disable claim when car is disconnected.
time_limit in minutes
session_energy in w/h
Todo:
fix #225