Skip to content
This repository was archived by the owner on Jun 18, 2024. It is now read-only.

added getuserbyid() to sharepointclient #67

Closed

Conversation

cjgehinscott
Copy link

added getuserbyid() to return user info from an ID

CJ added 3 commits February 5, 2015 11:06
created a getuserbyid() method to retrieve user information from an ID
added unit test for getuserbyid() method in sharepointclient
@cjgehinscott
Copy link
Author

@marcote Glad I could contribute!

I just added the unit test. Please let me know if you need anything else from me.

Best!

@marcote
Copy link
Contributor

marcote commented Feb 5, 2015

There is a local.properties file that shouldn't be part of the PR.
Also, I'm seeing some references to JUnit, and I think they're not required. The intent is correct, but I think you I lost you in the Test part.

Two options :

  • Try to remove all the added dependencies and/or imports into cjgehinscott@cc4d314 and see if you can mimic the other tests. We use a GUI test runner which is the app itself, not JUnit, maybe that was the confusing part.
  • Remove the Test from the PR and I will add it later ASAP. Most likely on Monday.

Thanks again

removed junit imports and removed the local.properties file
@cjgehinscott
Copy link
Author

@marcote I removed the imports. They snuck in there on me by accident from the autocomplete/import. I also removed the local.properties file. Let me know if that will work.

Best!

@marcote
Copy link
Contributor

marcote commented Feb 12, 2015

@cjgehinscott just a heads up to tell you I haven't forgotten about this. Just too much work on my plate.

@cjgehinscott
Copy link
Author

@marcote No problem. I have been working with a Microsoft Consultant on another problem and he is going to be doing a pull request for something else we found that will be useful. I'm glad this library is getting better and better.

marcote pushed a commit that referenced this pull request Mar 4, 2015
@marcote
Copy link
Contributor

marcote commented Mar 4, 2015

@cjgehinscott I had to remove the test, but I was able to merge your contribution to dev branch. You can see it here: 35c69c2 .

Thank you!

@marcote marcote closed this Mar 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants