Now using anti-aliasing on svg, updated NodeOS.ppm

[Coretool]

The quality of the ppm is better now but still not as good as the svg's !

[piranna]

Does "geometricPrecission" give better results? Shouldn't it be "crispEdges"?

[piranna]

https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/shape-rendering

[Coretool]

It outputs a really nice image compared to what I've got before. I'll test it with crispEdges again, but I'm not use if crispEdges really improves the quality of the picture

[Coretool]

The improvements are somewhat of the same. CrispEdges produces a "color-true" version with a bit of "damage" to the borders while geometricPrecission produces a, well, geometrically precise image. It's up to you :P

[piranna]

It should force to output borders with high contrast, reducing the numbers
of colours. If that's not enlught, then we'll need to reduce the palette of
the PNG image.

El 9/8/2016 16:30, "John Green" [email protected] escribió:

In NodeOS.svg
#3 (comment):

@@ -3,6 +3,7 @@
xmlns="http://www.w3.org/2000/svg"
width="56cm"
height="60cm"

• shape-rendering="geometricPrecision"

It outputs a really nice image compared to what I've got before. I'll test
it with crispEdges again, but I'm not use if crispEdges really improves the
quality of the picture

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NodeOS/media/pull/3/files/231d44d1dcfea0e3485b9048a4c589cd61cfc889#r74069206,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgfvqVaB_n6MG84BSfgYiJ8wCidwXdZks5qeI70gaJpZM4JgHOI
.

[piranna]

Can you show both to compare?

El 9/8/2016 16:35, "John Green" [email protected] escribió:

In NodeOS.svg
#3 (comment):

@@ -3,6 +3,7 @@
xmlns="http://www.w3.org/2000/svg"
width="56cm"
height="60cm"

• shape-rendering="geometricPrecision"

The improvements are somewhat of the same. CrispEdges produces a
"color-true" version with a bit of "damage" to the borders while
geometricPrecission produces a, well, geometrically precise image. It's up
to you :P

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NodeOS/media/pull/3/files/231d44d1dcfea0e3485b9048a4c589cd61cfc889#r74070287,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgfvjQuYgggeq-P6WrRK6gM7aXX-L4-ks5qeJArgaJpZM4JgHOI
.

[Coretool]

Using CrispEdges

Using the other one

[piranna]

Give them a try to both, but I think crispEdge will generate a better
result on the output ppm file.

I'm thinking that since it can be defined with CSS and would be nice to
remove the Gimp dependency, if it works we could check later to use
svgexport node.js module and give it an external CSS file defining the
edgeCrisp option, and maybe also fully automate the generation of the ppm
image, what do you think?

El 9/8/2016 16:42, "John Green" [email protected] escribió:

Using CrispEdges
[image: nodeos]
https://cloud.githubusercontent.com/assets/9163037/17520395/e487f49a-5e4f-11e6-877a-358a2d2effc3.png

Using the other one
[image: nodeos]
https://cloud.githubusercontent.com/assets/9163037/17520502/3f028412-5e50-11e6-9a17-ef27a9b9ecc9.png

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgfvu5o-Hlp0OsWosJ32yQHHoSoYlzeks5qeJHRgaJpZM4JgHOI
.

[Coretool]

Ok so I'll use the CrispEdge and later we will do what ? I was thinking about hardcoding the logo via diffs (just create a new file) and not generating it at runtime...

[piranna]

Yeah, include it on the diff patch, later we'll see what we do with the svg
and ppm file here on this repo.

El 9/8/2016 16:52, "John Green" [email protected] escribió:

Ok so I'll use the CrispEdge and later we will do what ? I was thinking
about hardcoding the logo via diffs (just create a new file) and not
generating it at runtime...

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgfvhCFonC3IjxeMwNpWREK_j0TYHMjks5qeJQ2gaJpZM4JgHOI
.

[Coretool]

Ok, fine.

[Coretool]

I tested crispEdges once again and yes, you were right. it produces indeed better ppms.

[piranna]

They are not the better, but for our use case it is ;-) In fact the O is
bit ugly compared to the other glyphs, but only solution here would be draw
it by hand. Are ppm without glitches? Can you send it?

El 10/8/2016 9:03, "John Green" [email protected] escribió:

I tested crispEdges once again and yes, you were right. it produces
indeed better ppms.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgfvtWuToAm3IOiqSRu1m6pUh2gbxDWks5qeXefgaJpZM4JgHOI
.

[Coretool]

The ppm is at my fork

[piranna]

Reviewed ;-) Don't know how it looks but the ppm code don't have glitches,
yay! :-D For me it's ready to add it on the patches, let's see later if we
add versions for different colors and resolution and to discuss what to do
with this repo, but I was thinking to move the crispEdges option to a CSS
file and remove the png and ppm images (they are generated products after
all, it could be added a script instead...).

El 10/8/2016 9:29, "John Green" [email protected] escribió:

the ppm is in this repo

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgfvkh5QFtO3sSIIyGURLPBo4VuG86Cks5qeX3igaJpZM4JgHOI
.

[Coretool]

Sure, that's fine !