Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/proxmox-image: update pve-qemu 8.1.5 -> 9.0.0 #327971

Closed
wants to merge 1 commit into from

Conversation

m010-cpu
Copy link

@m010-cpu m010-cpu commented Jul 17, 2024

Description of changes

Update pve-qemu version from 8.1.5 -> 9.0.0 because of dependencies issues while trying to generate proxmox images with proxmox-image.nix module.

https://wiki.qemu.org/ChangeLog/9.0
proxmox/pve-qemu@14afbdd

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 17, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 17, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 17, 2024
@m010-cpu m010-cpu changed the base branch from master to nixpkgs-unstable July 22, 2024 12:26
@m010-cpu m010-cpu changed the base branch from nixpkgs-unstable to nixos-unstable July 22, 2024 12:27
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4302

@m010-cpu m010-cpu changed the base branch from nixos-unstable to nixpkgs-unstable July 22, 2024 12:29
@gador
Copy link
Member

gador commented Jul 22, 2024

Thanks for your work. Could you please target master?

@m010-cpu m010-cpu changed the base branch from nixpkgs-unstable to master July 22, 2024 15:19
@m010-cpu
Copy link
Author

Thanks for your work. Could you please target master?

Done👍. When those changes are merged inside nixpkgs-unstable channel? Thanks in advance.

@gador
Copy link
Member

gador commented Jul 22, 2024

@ofborg eval

1 similar comment
@gador
Copy link
Member

gador commented Jul 22, 2024

@ofborg eval

@gador
Copy link
Member

gador commented Jul 22, 2024

same fix already merged in #328604
You can see the progress here

Although this PR isn't getting merged: Still thanks for your work!

@gador gador closed this Jul 22, 2024
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants