Add support for ignoring game assets #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ything in the `Content` folder.
fix a typeo in the comments
Al12rs
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #1578. The selection of files is game specific, and there should be a game specific setting for each game we support. So far this only includes SDV and the files ignored are in the
Contentsfolder. We could extend this to also ignore.dllfiles in the game folder, but it is assumed that those files are more likely to be overwritten by users and the files are not large. *The setting defaults to on in the current implementation, meaning new loadouts will not have the contents of the/Contentfolder backed up on SDV.This hooks into the existing Synchronizer logic and properly sets the
PathIgnoredflag in the Synchronizer, which was previously hardcoded asfalse.Initial Game management size:
Before this PR: ~450MB
After this PR: 48MB
10% reduction in backup sizes isn't bad!
Also implements an integration test for making sure the files truely are not backed up when the setting is enabled, and are when it is disabled.
Implemented as a predicate on
ALoadoutSynchronizerso any game need only override this method to take advantage of these features.Fixes: #1578