Disabled Creation of Multiple Loadouts for α Release #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh gosh, I'm going to be pedantic on this again. Didn't @Pickysaurus mention we wanted "Unsupported" not "Experimental"? Or was I not listening? |
The response was to the question 'What to name the setting to enable all games'. Which is called Because we don't have setting categories currently, I prepended text to the dangerous ones. I could make it so it says |
erri120
requested changes
May 23, 2024
src/NexusMods.App.UI/Controls/GameWidget/IGameWidgetViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/GameWidget/GameWidgetViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/GameWidget/GameWidgetViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/GameWidget/GameWidgetViewModel.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: erri120 <[email protected]>
erri120
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1389
This disables the creation of more than 1 loadout for the α Release.
The pill has been modified so the
Viewbutton stretches to the size of the remaining space.Post first α release, we can make the setting visible in Release builds.
(Currently this setting is Debug only and does not ship to users)
The pill with
Addbutton restored.Outside of that, unsupported games have been hidden from Release builds by default and the features have very clearly been marked as
Experimentalsince we don't yet have visible Settings categories.I also renamed the
manage-gameCLI command, since it was inaccurate with what it did given the recent changes. Somehow that slipped past review.