Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add migration tool migrate keyshares from GCP to local encrypted key file #246

Closed

Conversation

near-bookrock
Copy link
Contributor

This PR adds an option to the main CLI program to migrate key shares from GCP to local encrypted storage. The PR resolves
#245 .

@near-bookrock near-bookrock self-assigned this Mar 6, 2025
@andrei-near
Copy link
Contributor

andrei-near commented Mar 10, 2025

I think it would make sense to avoid GCP interactions all together and have mpc cli write given keyshare to local store using provided local encryption key. Since is a time operation, users would get their current keyshare and local encryption key from GCP manually and import to local store, something like this:

$ CURRENT_KEYSHARE='{"epoch":1,"private_share":"1111111111111111111111111111111111111111111111111111111111111111","public_key":"1111111111111111111111111111111111111111111111111111111111111111"}'
$ CURRENT_LOCAL_ENCRYPTION_KEY="AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
$ mpc-node import-keyshare $MY_CURRENT_KEYSHARE $CURRENT_LOCAL_ENCRYPTION_KEY

Additionally it simplifies the process as users will not have to authenticate on their non-GCP servers in order to fetch data from GCP Secret Manager

@bowenwang1996 bowenwang1996 marked this pull request as ready for review March 18, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants