Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv20230821 #79

Merged
merged 20 commits into from
Aug 25, 2023
Merged

Nv20230821 #79

merged 20 commits into from
Aug 25, 2023

Conversation

nvolk
Copy link
Contributor

@nvolk nvolk commented Aug 24, 2023

  • move prepublicationUtils.js away from here to marc-record-merge-validators-js project
  • Support field 946 (part of MET-461, the rest is in a validator)
  • uses under-development marc-record-merge-validators-js, that fixes various issues for us

@nvolk nvolk requested a review from ammsalme August 24, 2023 12:21
@nvolk nvolk requested a review from a team as a code owner August 24, 2023 12:21
Copy link
Contributor

@ammsalme ammsalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

946 should merge if it has identical $5:s too - or is this handled somewhere else?

@ammsalme ammsalme merged commit 46f6f1e into dev Aug 25, 2023
ammsalme added a commit that referenced this pull request Sep 1, 2023
* Nv20230821 (#79)

* Use prePublicationUtils from NatLibFi/marc-record-validators-melinda#205
* Handle local field 946 (MET-461)
* Bug fix: identical subfield $5s do not prevent fields from merging

* Update deps
* v2.0.15-alpha.2

* F946 tuning (#83)

* Refactor by moving various normalization functions from https://github.com/NatLibFi/melinda-marc-record-merge-reducers-js to https://github.com/NatLibFi/marc-record-validators-melinda
** See also: NatLibFi/marc-record-validators-melinda#208 

* Remove obsolete functions and comments, improve comments

* Add special treatment (normalization for subfields including part information) for 811$v and 830$v.

* Update f946 handling (MET-461)
** Use NatLibFi/marc-record-validators-melinda#208  

* Update deps

* 2.0.15-alpha.4

---------

Co-authored-by: nvolk <[email protected]>
@ammsalme ammsalme deleted the nv20230821 branch September 8, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants