-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nv20230821 #79
Merged
Merged
Nv20230821 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nvolk
commented
Aug 24, 2023
- move prepublicationUtils.js away from here to marc-record-merge-validators-js project
- Support field 946 (part of MET-461, the rest is in a validator)
- uses under-development marc-record-merge-validators-js, that fixes various issues for us
…da, it's no longer local
ammsalme
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
946 should merge if it has identical $5:s too - or is this handled somewhere else?
ammsalme
added a commit
that referenced
this pull request
Sep 1, 2023
* Nv20230821 (#79) * Use prePublicationUtils from NatLibFi/marc-record-validators-melinda#205 * Handle local field 946 (MET-461) * Bug fix: identical subfield $5s do not prevent fields from merging * Update deps * v2.0.15-alpha.2 * F946 tuning (#83) * Refactor by moving various normalization functions from https://github.com/NatLibFi/melinda-marc-record-merge-reducers-js to https://github.com/NatLibFi/marc-record-validators-melinda ** See also: NatLibFi/marc-record-validators-melinda#208 * Remove obsolete functions and comments, improve comments * Add special treatment (normalization for subfields including part information) for 811$v and 830$v. * Update f946 handling (MET-461) ** Use NatLibFi/marc-record-validators-melinda#208 * Update deps * 2.0.15-alpha.4 --------- Co-authored-by: nvolk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.