Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nv20230414 #44

Merged
merged 42 commits into from
Apr 26, 2023
Merged

Nv20230414 #44

merged 42 commits into from
Apr 26, 2023

Conversation

nvolk
Copy link
Contributor

@nvolk nvolk commented Apr 25, 2023

Ää, öh, mun piti PR:tä tää jo ties milloin. Wanhoja:

  • tue uudempaa validaattoriversiota
  • enablaa testejä, jotka on kirjoitettu aiemmin, mutta jotka eivät kirjoitushetkellä menneet läpi
  • MET-352 (väliviiivaerolliset 020$a:t)
  • varmaan muutakin

Tuoreemmin lisättyä:

  • lisätty tuki indikaattorivertailuihin säännöissä
  • estä 260 + 264 -kombon syntyminen (vrt. MELINDA-8383)
  • poistetaan kenttämergen jälkeen ja ennen add-vaihetta ne 264:t joille on basessa vastine (= sama ind2)

nvolk added 30 commits April 14, 2023 11:46
@nvolk
Test ISBN normalization as well (MELINDA-8362-ish)
3782274
@nvolk
Add 020$a ISBN value normalization to help field pairing decisions (d…
a80ab95 
…ehyphenate, uppercase 'x')
@nvolk
update dependency version
a8b173f
@nvolk
Set "skip" to false. Explain why punctuation does not get fixed.
505f5fe
@nvolk
Adjust result to punctuationless 490$a, as punctuation does not get f…
b60c7a2 
…ixed.
@nvolk
New 041 tests (the whole process, previously we only had merge specif…
c23cc91 
…ic 041 tests)
@nvolk
Tune merge specific 041 tests as we now also have whole process 041 t…
ec28eaf 
…ests
@nvolk
Enable test. Rewrite test to reflect current (and correct) behaviour.
58a47cb
@nvolk
Fix/update+enable test. Unable to merge two NR chains. Base's worse c…
65b784a 
…hain is retained.
@nvolk
Update marc-record-validators-melinda to ^10.3.2 and whatever depende…
c7b78e6 
…ncies
@nvolk
New test file for MET-345 (base $6 "TAG-NN" vs source "$6 TAG-NN/(N")
04249ca
@nvolk
Apply similar 040$d zxx removal rule that was previously applied to 0…
3ac67ba 
…40$a
@nvolk
remove all inferior datafields (also chain removals are now included/…
fa6ccde 
…supported)
@nvolk
make json more compact: remove various newlines etc
5c856cc
@nvolk
Empty modifiedSource from moved fields, as test now covers everything…
20dd0a3 
… and not just field merge
@nvolk
Add field 001
684e447
@nvolk
Delete file (moved under index and modified accordingly)
ad06449
@nvolk
Set "only" to false
547be40
@nvolk
New test file (= moved from merge to here + modified)
e1dea8a
@nvolk
New test fiel (= moved from merge to here + modified)
a24a0c4
@nvolk
New test file (= test moved from field merge to here + modified)
073c692
@nvolk
Set "skip" to false, as interpretation of things and their rightness …
371223f 
…has changed. Add comment.
@nvolk
New test file (MET-338; fields 520-880 chain)
aa51175
@nvolk
Add new test file for MET-336. However, currect SKIPPED! See metadata…
8054718 
….json for details.
@nvolk
New test (260->264 conversion)
b833a22
@nvolk
New test: conditionally add 264 fields (add if base does not have the…
65c1b1c 
… same 264ind2 field)
@nvolk
Rewrite test: source 260 is not modified, if base does not have 264
536bd59
@nvolk
modify test
f1533c4
@nvolk
Remove test. (Obsolete/double after changes in 260/264 logic)
7c75d65
@nvolk
New test (source 260$ef=>264$ab, since base has 264)
8068c36
@nvolk nvolk requested a review from ammsalme April 25, 2023 09:19
@nvolk nvolk requested a review from a team as a code owner April 25, 2023 09:19
@ammsalme ammsalme merged commit 19eca2d into main Apr 26, 2023
@ammsalme ammsalme deleted the nv20230414 branch April 26, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammsalme ammsalme ammsalme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvolk @ammsalme