Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv20230325 #35

Merged
merged 38 commits into from
Apr 3, 2023
Merged

Nv20230325 #35

merged 38 commits into from
Apr 3, 2023

Conversation

nvolk
Copy link
Contributor

@nvolk nvolk commented Mar 28, 2023

  • use up-to-date melinda-marc-record-validators (Fix at least MRA-487, affects others as well)
  • update some other natlibfi dependencies as well
  • improved subfield order and subfield merge rules (Fix MRA-412, MRA-450, MRA-490, MRA-503)
  • Fix MRA-520 (LDR/05 c vs n)

nvolk added 29 commits March 24, 2023 16:26
* Node v14 -> v18

*  Update marc-record-validators-melinda: v1.2.3 (https://github.com/NatLibFi/marc-record-validators-melinda/tree/v10.2.3)

* Update dependencies

* Updates to handling subfield $9
** Add <TRANS> support. 
** Rewrite of/bug fixes for <KEEP> and <DROP> support.

* Updates to handling 7xx linking (f766-f780) fields (MRA-487)

* Updates to avoid duplicating f300 subfield $a (MRA-490)

* Reduce and modify logging

* 2.0.0-alpha.1
…a extraction more robust (vs ending punctuation)
… a new version of marc-record-melinda-validators!
…t hyphenated and hyphenated version are considered the same.
@nvolk nvolk requested a review from ammsalme March 28, 2023 19:53
@nvolk nvolk requested a review from a team as a code owner March 28, 2023 19:53
@@ -3,7 +3,7 @@ import {nvdebug} from './utils';
// Normalizes at least 490$v and 773$g which contain information such as "Raita 5" vs "5", and "Osa 3" vs "Osa III".

export function subfieldContainsPartData(tag, subfieldCode) {
if (tag === '490' && subfieldCode === 'v') {
if (subfieldCode === 'v' && ['490', '800', '810'].includes(tag)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add also 811 $v and 830 $v here.

@ammsalme ammsalme merged commit cc026ca into dev Apr 3, 2023
@ammsalme ammsalme deleted the nv20230325 branch April 3, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants