Nv20230325 #35
Merged
Nv20230325 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nvolk
commented
Mar 28, 2023
nvolk
commented
- use up-to-date melinda-marc-record-validators (Fix at least MRA-487, affects others as well)
- update some other natlibfi dependencies as well
- improved subfield order and subfield merge rules (Fix MRA-412, MRA-450, MRA-490, MRA-503)
- Fix MRA-520 (LDR/05 c vs n)
* Node v14 -> v18 * Update marc-record-validators-melinda: v1.2.3 (https://github.com/NatLibFi/marc-record-validators-melinda/tree/v10.2.3) * Update dependencies * Updates to handling subfield $9 ** Add <TRANS> support. ** Rewrite of/bug fixes for <KEEP> and <DROP> support. * Updates to handling 7xx linking (f766-f780) fields (MRA-487) * Updates to avoid duplicating f300 subfield $a (MRA-490) * Reduce and modify logging * 2.0.0-alpha.1
…a extraction more robust (vs ending punctuation)
…reating near-identical (R) subfields)
… a new version of marc-record-melinda-validators!
…t hyphenated and hyphenated version are considered the same.
…'t do anything stupid with them fields.
…r use local punctuation.js)
….js functionalities
Move development debugging to debugDev
ammsalme
approved these changes
Apr 3, 2023
| @@ -3,7 +3,7 @@ import {nvdebug} from './utils'; | |||
| // Normalizes at least 490$v and 773$g which contain information such as "Raita 5" vs "5", and "Osa 3" vs "Osa III". | |||
|
|
|||
| export function subfieldContainsPartData(tag, subfieldCode) { | |||
| if (tag === '490' && subfieldCode === 'v') { | |||
| if (subfieldCode === 'v' && ['490', '800', '810'].includes(tag)) { | |||
There was a problem hiding this comment.
We could add also 811 $v and 830 $v here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.