Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv20230317 #32

Merged
merged 15 commits into from
Mar 20, 2023
Merged

Nv20230317 #32

merged 15 commits into from
Mar 20, 2023

Conversation

nvolk
Copy link
Contributor

@nvolk nvolk commented Mar 17, 2023

  • Fix MRA-414 ($9 handling had a bug)
  • Fix MRA-431 (Add paired 880 $6 TAG -removal for NR fields such as 245. Change:Remove NR fields before adding fields, not during it)
  • Add MRA-422 related test. The actual issue is a feature, not a bug.
  • Minor punctuation improvements

Huom: Saman päivän havainnoista MRA-430:n 700-880-$e-jutut yms. olen tietoisesti jättänyt tekemättä, eli noiden yhdistymättömyys on feature. Ohjelman logiikka lisätä osakenttiä sourcesta baseen toimii vain $6-ketjuttamattomissa kentissä, kun ei voida olla varmoja, miten lisäykset toimis vastaparikenttään. (Joillain osakentillä saatettas kait haluta käyttää muita merkistöjä 880:ssa yms.) Toteutus olis sekä hankala että riskaabeli mun mielestä.

Olipas tossa looginen kielenvaihto lennosta.

@nvolk nvolk requested a review from ammsalme March 17, 2023 20:10
@nvolk nvolk requested a review from a team as a code owner March 17, 2023 20:10
@ammsalme ammsalme merged commit b411937 into main Mar 20, 2023
@ammsalme ammsalme deleted the nv20230317 branch March 20, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants