Metatietoputki20230302 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nder new normalizeForSamenessCheck(tag, subfieldCode, originalValue)
…ported field+subfields.
ammsalme
approved these changes
Mar 6, 2023
ammsalme
added a commit
that referenced
this pull request
Mar 6, 2023
* Fix MRA-309 and MRA-311. Gather all sameness-related normalizations under new normalizeForSamenessCheck(tag, subfieldCode, originalValue) * Fix/tune merge contraints for fields 041, 084 and 534 * Add some punctuation rules to fields 506 and 534 * Log less * Add more tests * 1.2.2-alpha.1 Co-authored-by: nvolk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MRA-309 and MRA-311
Add tests for other stuff (incl. MRA-223) as well.
Somewhat smaller update. Mainly work on given field/subfield sameness-check-only normalization. No preference is given, so base value win (eg. 506$a S vs Sallittu vs Sallittu kaikenikäisille), though sometimes the correct value for 506$a is sometimes known (Here "Sallittu kaikenikäisille" is the form that is used in MTS)