Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metatietoputki20230302 #26

Merged
merged 15 commits into from
Mar 6, 2023
Merged

Metatietoputki20230302 #26

merged 15 commits into from
Mar 6, 2023

Conversation

nvolk
Copy link
Contributor

@nvolk nvolk commented Mar 2, 2023

Fix MRA-309 and MRA-311

Add tests for other stuff (incl. MRA-223) as well.

Somewhat smaller update. Mainly work on given field/subfield sameness-check-only normalization. No preference is given, so base value win (eg. 506$a S vs Sallittu vs Sallittu kaikenikäisille), though sometimes the correct value for 506$a is sometimes known (Here "Sallittu kaikenikäisille" is the form that is used in MTS)

@nvolk nvolk requested a review from ammsalme March 2, 2023 20:28
@nvolk nvolk requested a review from a team as a code owner March 2, 2023 20:28
@ammsalme ammsalme changed the base branch from main to dev March 6, 2023 15:01
@ammsalme ammsalme changed the base branch from dev to main March 6, 2023 15:01
@ammsalme ammsalme changed the base branch from main to dev March 6, 2023 15:02
@ammsalme ammsalme merged commit 57025b7 into dev Mar 6, 2023
@ammsalme ammsalme deleted the metatietoputki20230302 branch March 6, 2023 15:04
ammsalme added a commit that referenced this pull request Mar 6, 2023
* Fix MRA-309 and MRA-311. Gather all sameness-related normalizations under new normalizeForSamenessCheck(tag, subfieldCode, originalValue)
* Fix/tune merge contraints for fields 041, 084 and 534
* Add some punctuation rules to fields 506 and 534

* Log less
* Add more tests

* 1.2.2-alpha.1

Co-authored-by: nvolk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants