Updates to merging (#23) #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates to merging - Better recognition of different language versions of f020 subfield $q qualifiers as same - Better recognition of different language versions of fX00 subfield $e creator roles as same - Recognise subfield $6 indexes with value greater than 99 - Handle cases where paired fields have the same index, but a different tag in subfield $6 - Ignore differences in indicators when merging 5xx fields: 505, 506, 510, 511, 516, 520, 521, 522, 524, 526, 583, 586 -- Prefer indicator from field that has sf $9 FENNI<KEEP> if exists, otherwise prefer indicator from field from base * More tests
nvolk
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better recognition of different language versions of f020 subfield $q qualifiers as same
Better recognition of different language versions of fX00 subfield $e creator roles as same
Recognise subfield $6 indexes with value greater than 99
Handle cases where paired fields have the same index, but a different tag in subfield $6
Ignore differences in indicators when merging 5xx fields: 505, 506, 510, 511, 516, 520, 521, 522, 524, 526, 583, 586 -- Prefer indicator from field that has sf $9 FENNI if exists, otherwise prefer indicator from field from base