Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to merging (#23) #24

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Updates to merging (#23) #24

merged 1 commit into from
Mar 1, 2023

Conversation

ammsalme
Copy link
Contributor

@ammsalme ammsalme commented Mar 1, 2023

  • Updates to merging
  • Better recognition of different language versions of f020 subfield $q qualifiers as same

  • Better recognition of different language versions of fX00 subfield $e creator roles as same

  • Recognise subfield $6 indexes with value greater than 99

  • Handle cases where paired fields have the same index, but a different tag in subfield $6

  • Ignore differences in indicators when merging 5xx fields: 505, 506, 510, 511, 516, 520, 521, 522, 524, 526, 583, 586 -- Prefer indicator from field that has sf $9 FENNI if exists, otherwise prefer indicator from field from base

  • More tests

* Updates to merging

- Better recognition of different language versions of f020 subfield $q qualifiers as same
- Better recognition of different language versions of fX00 subfield $e creator roles as same

- Recognise subfield $6 indexes with value greater than 99
- Handle cases where paired fields have the same index, but a different tag in subfield $6

- Ignore differences in indicators when merging 5xx fields: 505, 506, 510, 511, 516, 520, 521, 522, 524, 526, 583, 586
-- Prefer indicator from field that has sf $9 FENNI<KEEP> if exists, otherwise prefer indicator from field from base 

* More tests
@ammsalme ammsalme marked this pull request as ready for review March 1, 2023 10:21
@ammsalme ammsalme requested a review from a team as a code owner March 1, 2023 10:21
Copy link
Contributor

@nvolk nvolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly disqualified (as in "jäävi"), but here we go...

@nvolk nvolk merged commit 273a876 into main Mar 1, 2023
@ammsalme ammsalme deleted the dev branch March 6, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants