Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Met 571 v2 #206

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Met 571 v2 #206

merged 4 commits into from
Aug 7, 2024

Conversation

nvolk
Copy link
Contributor

@nvolk nvolk commented Aug 6, 2024

Handle MET-571 input + update dependencies

@nvolk nvolk requested a review from a team as a code owner August 6, 2024 08:18
aatuny
aatuny approved these changes Aug 6, 2024
View reviewed changes
Copy link

@aatuny aatuny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if Fikka/Fenni LOW-tags are interchangeable. Otherwise we'll have to double check that rule takes into account both tags when LDR/17 != 8.

@natlibfi-jonollil natlibfi-jonollil merged commit 8289270 into next Aug 7, 2024
5 checks passed
@natlibfi-jonollil natlibfi-jonollil deleted the MET-571-v2 branch August 7, 2024 05:35
natlibfi-jonollil added a commit that referenced this pull request Aug 7, 2024
@natlibfi-jonollil @nvolk
Next (#207)
cf4fc0b 
* Met 571 v2 (#206)

* update dependencies
* new tests
* MET-571

* Update melinda-node-tests.yml
Add container to run njsscan in to

---------

Co-authored-by: nvolk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aatuny aatuny aatuny approved these changes

@natlibfi-jonollil natlibfi-jonollil natlibfi-jonollil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvolk @aatuny @natlibfi-jonollil