Code

008/18-34 fixes, round 1#142

Code

Merged

ammsalme merged 81 commits intonextNatLibFi/melinda-marc-record-merge-reducers-js:nextfrom formOfItemNatLibFi/melinda-marc-record-merge-reducers-js:formOfItemCopy head branch name to clipboardFeb 13, 2024

Commits

Commits on Jan 18, 2024

• Add code for (cherry)picking better 008/XX-YY values from source record

  nvolk

  committed
  db4492d

  Copy full SHA for db4492d

• New test for 008/18-34

  nvolk

  committed
  170b6a3

  Copy full SHA for 170b6a3

• Disable console logs

  nvolk

  committed
  eefc20c

  Copy full SHA for eefc20c

• Greatly improve support for 008/18-34 merge

  nvolk

  committed
  49d8383

  Copy full SHA for 49d8383

Commits on Jan 24, 2024

• Check that type of material is same in both records before merging 008/18-34

  nvolk

  committed
  527a476

  Copy full SHA for 527a476

• Update package-lock.json dependencies

  nvolk

  committed
  ad97872

  Copy full SHA for ad97872

• Rewrite incl. rules can be applied even when records are of different types

  nvolk

  committed
  81bd766

  Copy full SHA for 81bd766

• New test (mismatching type of material with some shared character positions)

  nvolk

  committed
  f8ec767

  Copy full SHA for f8ec767

• Add explicit return command, and a debugging related comment.

  nvolk

  committed
  873c447

  Copy full SHA for 873c447

• Refactor a bit. Handle conflicting types of material (some character positions may be shared).

  nvolk

  committed
  3a8d0d1

  Copy full SHA for 3a8d0d1

Commits on Jan 25, 2024

• minor refactoring

  nvolk

  committed
  1b85319

  Copy full SHA for 1b85319

• export hasLegalLength(). Simplify code a bit.

  nvolk

  committed
  355d399

  Copy full SHA for 355d399

• Rewrite rules for 006 mergeability check (better support for multicharacter data)

  nvolk

  committed
  86f7cf5

  Copy full SHA for 86f7cf5

• make field 008 related rules usable by field 006.

  nvolk

  committed
  c766e59

  Copy full SHA for c766e59

• Add some support for field 006 as 006/01-17 and 008/18-34 are the same

  nvolk

  committed
  e4395e8

  Copy full SHA for e4395e8

• Change is functionality: use field 008 stuff for 006/101-17

  nvolk

  committed
  de18fed

  Copy full SHA for de18fed

• New test (with 006/01-17 data aped from corresponding 008/18-34 test)

  nvolk

  committed
  9c8c27d

  Copy full SHA for 9c8c27d

• Add explicit "only":false

  nvolk

  committed
  bd2c627

  Copy full SHA for bd2c627

• Minor refactoring. No functional changes.

  nvolk

  committed
  1d052f2

  Copy full SHA for 1d052f2

• bug fix: call setForOfItem() only once, not for once-per-every-rule

  nvolk

  committed
  3cb2d82

  Copy full SHA for 3cb2d82

• Add few descriptions

  nvolk

  committed
  3dfcded

  Copy full SHA for 3dfcded

• bug fix: call setFormOfItem() only once.

  nvolk

  committed
  0c92dfa

  Copy full SHA for 0c92dfa

• New test (reasons for skipping field 006 merge)

  nvolk

  committed
  4b933f7

  Copy full SHA for 4b933f7

• New test (online resource 006/06 'o' vs 's')

  nvolk

  committed
  5c1b401

  Copy full SHA for 5c1b401

• setFormOfItem(): add 4th parameter for sourceTypeOfMaterail; form of item position can now be different in the two fields.

  nvolk

  committed
  675618b

  Copy full SHA for 675618b

• Form of item o-vs-s and q-vs-s expections no longer prevent field 006 merge

  nvolk

  committed
  e926de4

  Copy full SHA for e926de4

Commits on Jan 26, 2024

• modify and extend test

  nvolk

  committed
  bdab913

  Copy full SHA for bdab913

• New test

  nvolk

  committed
  9af2e30

  Copy full SHA for 9af2e30

• update test description

  nvolk

  committed
  f9217c4

  Copy full SHA for f9217c4

• Tune BK 008/33 (and 006/16) merge: more specific values replace base's '1'

  nvolk

  committed
  bf52466

  Copy full SHA for bf52466

• Bunch of bug fixes + better BK 006/16 support

  nvolk

  committed
  f3de1a3

  Copy full SHA for f3de1a3

• new test

  nvolk

  committed
  29d1a1e

  Copy full SHA for 29d1a1e

• Tune test to improve coverage.

  nvolk

  committed
  d2bb169

  Copy full SHA for d2bb169

• set "only" to false

  nvolk

  committed
  2d83ad3

  Copy full SHA for 2d83ad3

• Rewrite. Use rules to determine mergability. First half of the rules written now.

  nvolk

  committed
  38b7f01

  Copy full SHA for 38b7f01

Commits on Jan 29, 2024

• Explicitly set "only" to false.

  nvolk

  committed
  3bdafff

  Copy full SHA for 3bdafff

• rules for field 007: v. 1.0

  nvolk

  committed
  b609ca2

  Copy full SHA for b609ca2

• Merge branch 'main' into formOfItem

  ammsalme

  committed
  91d8bd0

  Copy full SHA for 91d8bd0

• comment out console stuff

  nvolk

  committed
  c4d7add

  Copy full SHA for c4d7add

• Add some commented unfinished code

  nvolk

  committed
  1ab7d1f

  Copy full SHA for 1ab7d1f

• Make the test a tiny bit more illustrative

  nvolk

  committed
  c75e1f4

  Copy full SHA for c75e1f4

Commits on Jan 30, 2024

• new test (merge 007/00=a pair)

  nvolk

  committed
  2dae080

  Copy full SHA for 2dae080

• "Is value meaningful?" check now checks whether character position value is mapped as "valueForUnknown" in some rule. No more hacky if-value-is-u rules...

  nvolk

  committed
  85d3eee

  Copy full SHA for 85d3eee

• new file

  nvolk

  committed
  6a28be9

  Copy full SHA for 6a28be9

• bug fixes and tuning

  nvolk

  committed
  8dd1d44

  Copy full SHA for 8dd1d44

• New file (test spaces that carry meaning)

  nvolk

  committed
  f72ae24

  Copy full SHA for f72ae24

• Merge branch 'formOfItem' of https://github.com/NatLibFi/melinda-marc-record-merge-reducers-js into formOfItem

  nvolk

  committed
  fb3b8dc

  Copy full SHA for fb3b8dc

• update dependencies

  nvolk

  committed
  fc8a44b

  Copy full SHA for fc8a44b

Commits on Jan 31, 2024

• Comment out a console.info() command

  nvolk

  committed
  4ebc425

  Copy full SHA for 4ebc425

• Rewrite handling of 008 fields, if length!=40

  nvolk

  committed
  a2d8e4a

  Copy full SHA for a2d8e4a

• Tune. Mainly rewrite handling of missized fields

  nvolk

  committed
  68283f6

  Copy full SHA for 68283f6

• Rewrite mis-sized field 006 handling

  nvolk

  committed
  9650e0f

  Copy full SHA for 9650e0f

• Remove obsolete code

  nvolk

  committed
  37418ba

  Copy full SHA for 37418ba

Commits on Feb 12, 2024

• update dependencies

  nvolk

  committed
  154eb16

  Copy full SHA for 154eb16

• new test

  nvolk

  committed
  cf8a6e6

  Copy full SHA for cf8a6e6

• Add field.tag to subfieldData, as it will be passed on and used in mergeOrAddSubfield.js

  nvolk

  committed
  68f9f04

  Copy full SHA for 68f9f04

• Allow 1XX vs 7XX to merge even if 7XX has a $9 <KEEP> subfield. NB! $9 <KEEP> is not merged into 1XX.

  nvolk

  committed
  e3db6da

  Copy full SHA for e3db6da

• Implement image bit depth (ER 007/06-08) merge rules

  nvolk

  committed
  8e623a3

  Copy full SHA for 8e623a3

• Fix test. (It now supports image bit depth merge.)

  nvolk

  committed
  3e64280

  Copy full SHA for 3e64280

• Modify (07/03-04, class of braille writing) values to reflect our "keep it simple" solution

  nvolk

  committed
  80d2a7b

  Copy full SHA for 80d2a7b

• Modify test as tactile 007/06-08 handling changed.

  nvolk

  committed
  104e84a

  Copy full SHA for 104e84a

• Add better reduction ratio to source and merged 007/06-08.

  nvolk

  committed
  db77de2

  Copy full SHA for db77de2

• Handle some multi-slot 007/XX-YY values. (And leave some undone on purpose.)

  nvolk

  committed
  53e66a2

  Copy full SHA for 53e66a2

• Include my first BK 008/18-21 illustration test

  nvolk

  committed
  d38a7d7

  Copy full SHA for d38a7d7

• Support BK 008/18-21 (illustrations) merge

  nvolk

  committed
  1899f83

  Copy full SHA for 1899f83

• Set only to false

  nvolk

  committed
  9a713d4

  Copy full SHA for 9a713d4

• Add 100 vs 700-with-keep test

  nvolk

  committed
  d69fbb4

  Copy full SHA for d69fbb4

Commits on Feb 13, 2024

• Sort BK 008/18-21 values. List and pick only legal BK 008/18-21 values.

  nvolk

  committed
  b39687a

  Copy full SHA for b39687a

• Sort BK 008/18-21 values

  nvolk

  committed
  4050dfa

  Copy full SHA for 4050dfa

• Refactor.

  nvolk

  committed
  deae188

  Copy full SHA for deae188

• Add stuff for 008/24-27 (nature of contents)

  nvolk

  committed
  1886caf

  Copy full SHA for 1886caf

• Source 008/25-27 (fields of contents) gets now copied

  nvolk

  committed
  5251faf

  Copy full SHA for 5251faf

• Bug fix: I added crap to 008/11-14

  nvolk

  committed
  bff747b

  Copy full SHA for bff747b

• set only to false

  nvolk

  committed
  c18fb92

  Copy full SHA for c18fb92

• New test

  nvolk

  committed
  24f9922

  Copy full SHA for 24f9922

• Add rules for BK/CR nature of contents (008/24-27)

  nvolk

  committed
  f2388a2

  Copy full SHA for f2388a2

• Handle all 008/18-34 range multichar rules. Add generic multichar handling code ans use it wherever possible.

  nvolk

  committed
  821561a

  Copy full SHA for 821561a

• Include 008/24-29 (accompanying matter) and 008/30-31 literary text for sound recordings into the test

  nvolk

  committed
  809b598

  Copy full SHA for 809b598

• Include proper 008/18-21 (relief) and 008/33-34 special format characteristics into the map test.

  nvolk

  committed
  706c599

  Copy full SHA for 706c599

• Comment all console.info calls

  nvolk

  committed
  5d13953

  Copy full SHA for 5d13953

• 2.1.0-alpha.1

  ammsalme

  committed
  fbe03e0

  Copy full SHA for fbe03e0