Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap via config, duplicate field/subfield fixes & maintenance update #14

Merged
merged 5 commits into from
Feb 2, 2023

Conversation

ammsalme
Copy link
Contributor

@ammsalme ammsalme commented Feb 2, 2023

No description provided.

nvolk and others added 5 commits February 2, 2023 15:32
As per branch name: Move swapping functionality (needed for Muuntaja) from code to config file.

Also this branch contains various fixes to handle lately emerged bugs in field and subfield repetition. Fixes include but are not limited to:

more trimming and better punctuation rules (so that duplicate would not happen)
duplicate subfield removal functionality
fixes in subfield sort rules

Other stuff:

counterpart field detection: name must match, mere $0 match is no longer good enough for pairing (bunch of tests turned off because of this)

$xyz pairing requirement for 600, 610, 611 and 630


* Update dependencies

---------

Co-authored-by: Minttu Hurme <[email protected]>
@ammsalme ammsalme requested a review from a team as a code owner February 2, 2023 13:42
@ammsalme ammsalme changed the title Swap via config and duplicate field/subfield fixes Swap via config, duplicate field/subfield fixes & maintenance update Feb 2, 2023
@ammsalme ammsalme merged commit 1ed31fe into main Feb 2, 2023
@ammsalme ammsalme deleted the dev branch February 2, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants