Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit both 710 and sf5 #114

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Revisit both 710 and sf5 #114

merged 6 commits into from
Nov 10, 2023

Conversation

nvolk
Copy link
Contributor

@nvolk nvolk commented Nov 10, 2023

Fix MET-502: make field 884 mergeable, set merge constraints for it. Also fix a bug in field counterpart decisions. (Controlfields $5 and $9 were used in name&title part comparisons, if no subfield code was required. Removed these controlfields from comparisons).

Improve MELINDA-8978: if source has an Asteri $0, and the counterpart base field has not, use the source field as the field, to which the other fields' subfields are merged.

@nvolk nvolk requested a review from ammsalme November 10, 2023 12:08
@nvolk nvolk requested a review from a team as a code owner November 10, 2023 12:08
@ammsalme ammsalme merged commit d32e376 into next Nov 10, 2023
@ammsalme ammsalme deleted the revisit_both_710_and_sf5 branch November 10, 2023 15:17
ammsalme added a commit that referenced this pull request Nov 15, 2023
Bump the development-dependencies group with 2 updates (#113)
* Updates `@babel/core` from 7.23.2 to 7.23.3
* Updates `@babel/preset-env` from 7.23.2 to 7.23.3

Revisit both 710 and sf5 (#114)

* Permit merge of field 884 [MET-502]
-- Fix [MET-502]: make field 884 mergeable, set merge constraints for it. Also fix a bug in field counterpart decisions. (Controlfields $5 and $9 were used in name&title part comparisons, if no subfield code was required. Removed these controlfields from comparisons).

* Better handling of publishers [MELINDA-8978]
-- If source has an Asteri $0, and the counterpart base field has not, use the source field as the field, to which the other fields' subfields are merged.

[MET-502]: add support for 710$a "Basename Kustannus" vs "Basename" pairing. (#116)


* 2.0.21-alpha.3

Co-authored-by: nvolk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants