Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

245punc #107

Merged
merged 11 commits into from
Nov 8, 2023
Merged

245punc #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5635e03
Bump actions/setup-node from 3 to 4 (#102)
dependabot[bot] Oct 24, 2023
16aaf6f
Bump the production-dependencies group with 1 update (#103)
dependabot[bot] Oct 24, 2023
e87c718
Bump the development-dependencies group with 1 update (#101)
dependabot[bot] Oct 24, 2023
e95468d
2.0.19-alpha.1
ammsalme Oct 24, 2023
4f736d7
Upddate field sorting (#105)
nvolk Oct 26, 2023
cf8ee0e
Pair http and https [MET-501] (#106)
nvolk Oct 30, 2023
3b8619b
new test
nvolk Oct 31, 2023
18a7966
use a branch of marc-record-validators-melinda
nvolk Oct 31, 2023
03fbd49
Merge branch 'main' into 245punc
ammsalme Nov 3, 2023
be2377e
Update deps
ammsalme Nov 3, 2023
db60f23
2.0.20-alpha.2
ammsalme Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"url": "[email protected]:natlibfi/melinda-marc-record-merge-reducers-js.git"
},
"license": "LGPL-3.0+",
"version": "2.0.19",
"version": "2.0.20-alpha.2",
"main": "./dist/index.js",
"engines": {
"node": ">=18"
Expand All @@ -39,9 +39,8 @@
"@natlibfi/marc-record": "^8.0.0",
"@natlibfi/marc-record-merge": "^7.0.0",
"@natlibfi/marc-record-validate": "^8.0.3",
"@natlibfi/marc-record-validators-melinda": "^10.15.0",
"@natlibfi/marc-record-validators-melinda": "https://github.com/NatLibFi/marc-record-validators-melinda.git#245punc",
"@natlibfi/melinda-commons": "^13.0.7",
"clone": "^2.1.2",
"debug": "^4.3.4",
"isbn3": "^1.1.43",
"normalize-diacritics": "^4.0.3"
Expand Down
11 changes: 11 additions & 0 deletions test-fixtures/reducers/index/245_punc20231031_via_slack/base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"leader": "01331cam a22003494i 4500",
"fields": [
{ "tag": "001", "value": "12345"},

{ "tag": "245", "ind1": "0", "ind2": "0", "subfields": [
{ "code": "a", "value": "Suomen laki." },
{ "code": "n", "value": "II." }
] }
]
}
13 changes: 13 additions & 0 deletions test-fixtures/reducers/index/245_punc20231031_via_slack/merged.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"leader": "01331cam a22003494i 4500",
"fields": [
{ "tag": "001", "value": "12345"},

{ "tag": "245", "ind1": "0", "ind2": "0", "subfields": [
{ "code": "a", "value": "Suomen laki." },
{ "code": "n", "value": "II /" },
{ "code": "c", "value": "Etunimi Sukunimi, tomittaja." }
] }

]
}
4 changes: 4 additions & 0 deletions test-fixtures/reducers/index/245_punc20231031_via_slack/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"description":"Field 245 punctuation issue discussed via slack on 2023-10-31",
"only": false
}
6 changes: 6 additions & 0 deletions test-fixtures/reducers/index/245_punc20231031_via_slack/modifiedSource.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"leader": "01331cam a22003494i 4500",
"fields": [
{ "tag": "001", "value": "123456"}
]
}
13 changes: 13 additions & 0 deletions test-fixtures/reducers/index/245_punc20231031_via_slack/source.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"leader": "01331cam a22003494i 4500",
"fields": [
{ "tag": "001", "value": "123456"},

{ "tag": "245", "ind1": "0", "ind2": "0", "subfields": [
{ "code": "a", "value": "Suomen laki." },
{ "code": "n", "value": "II /" },
{ "code": "c", "value": "Etunimi Sukunimi, tomittaja." }
] }

]
}