Updates to fix CapacitySpectrumMethod app for local workflows #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add error messages when length_unit or time_unit is missing from AIM - Try to be conservative with creating new variables just for the sake of more concise dictionary access - gm_units uses "g" for now, but make sure the following code will work even when we potentially generalize beyond "g". Throw an error when an expected gm_unit is encountered. - Extend run_csm to save the capacity curves in a JSON file to support post-processing. - Refactor determine_response to start with opening inputs and checking if they are valid. - Change some variable names to be more descriptive and avoid using upper case letters. - Parse the demand, capacity, and damping models early on once rather than parsing them once for each direction. We could also initialize the models early, but I am not sure they'll behave well when applied multiple times. It seemed safer to initialize them for each direction separately for the time being. Further improvements seem like low hanging fruits in that department. - Improve how roof height is loaded. Further improvements are planned by taking care of how roof height is saved in GeneralInformation. - Add scaling of roof height by considering the workflow units and the internal units of the CSM script - Now that the capacity model is loaded ahead of time, loading the default roof height from Hazus will actually work. - Add a temporary fix to scale PEER timehistories assuming [g] units rather than using the workflow units from AIM. This will be improved later. - Extend IMComputer part to also extract PGA and store it as PFA-0-1 - Add comments about the various unit conversions so that future devs might find it easier to follow what is happening. - Improve how accel_x and accel_y are loaded from response_accel - Scale the resulting spectral accelerations back to the workflow units before saving them in the EDP file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.