Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove node installation in Dockerfile #21

Merged
merged 1 commit into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-lib-c-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
tar -czf ${{ matrix.platform }}.tar.gz *

- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: binaries
path: ./binaries/${{ matrix.platform }}.tar.gz
1 change: 0 additions & 1 deletion LIBHEIF_VERSION

This file was deleted.

3 changes: 0 additions & 3 deletions platform/linux-x64/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ RUN apt-get update && \
python3-mako \
&& rm -rf /var/lib/apt/lists/*

RUN curl -sL https://deb.nodesource.com/setup_20.x | bash - && \
apt-get install -y nodejs

RUN git clone https://github.com/microsoft/vcpkg.git && \
./vcpkg/bootstrap-vcpkg.sh && \
./vcpkg/vcpkg install libheif
1 change: 0 additions & 1 deletion platform/win32-ia32/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ RUN powershell -NoProfile -ExecutionPolicy Bypass -Command \
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; \
iex ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1'))"

RUN choco install -y nodejs --version=20.9.0 --x86
RUN choco install -y git visualstudio2019buildtools visualstudio2019-workload-vctools
RUN choco install -y python3

Expand Down
1 change: 0 additions & 1 deletion platform/win32-x64/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ RUN powershell -NoProfile -ExecutionPolicy Bypass -Command \
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; \
iex ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1'))"

RUN choco install -y nodejs --version=20.9.0
RUN choco install -y git visualstudio2019buildtools visualstudio2019-workload-vctools
RUN choco install -y python3

Expand Down
Loading