ONNX updates #527
Merged
ONNX updates #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandeep Pillai <[email protected]>
For some reason, for some ops, the opset version is set to the miniumum supported version. For certain ops, this is version 1. The ONNX runtime is printing a warning about any version less than 7. So, if the opset version is less than 7, opset_version.
To ensure keras_model.py is run before the keras_to_MDF.py which uses the model, I excluded them from examples and instead import them from keras_to_MDF.py.
Ok, I think that keras_model.py is not running twice in some cases because the module with the same name is getting cached. I have re-included it and it seems that it should always run first anyway.
Actually, I don't like depending on test execution order. If we ever parallelize tests this will be bad. Lets try using exec. I think this will ensure the keras_model.py that is local to the script runs each and every time.
Since we are executing the keras_model.py in the callspace we don't even need to serialize\deserialize model.
Maybe they work now?
Fix minimum opset version used for ONNX op execution, Tensorflow Import Fixes
Added import os in examples/MDF/simple.py
Updates to actions; regenerated some images
Specification of termination condition in ACT-R models is breaking with changes to graphscheduler. I have disabled the termination condition specification for now. Examples seem to still run but they are not check outputs so can't say for sure this is the proper fix.
Fix/actr test condition
added arctan, arccos and arcsin functions and an example file using them
Fix to CI and regenerated images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.