Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "SetZoom update the method to calculate the trans" #514

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Conversation

hannesa2
Copy link
Collaborator

This reverts commit bc7b506.

@hannesa2
Copy link
Collaborator Author

close #507

@hannesa2
Copy link
Collaborator Author

hannesa2 commented Jan 22, 2023

As expected the zoom is now different (thanks to #513 the CI do a verification)
image

@SimFG it reverts your pull request #329 and handles #507 and #506
To be honest, I don't know if I should revert it or not. What do you think @SimFG and @bartek-wesolowski ?

I'm open to any solution.

@hannesa2
Copy link
Collaborator Author

close #506

@hannesa2
Copy link
Collaborator Author

And it founds more differences https://github.com/MikeOrtiz/TouchImageView/suites/10513010901/artifacts/522001897
I think the screenshot comparison mechanism is not perfect and the init status is confusing too
image

@bartek-wesolowski
Copy link

I think reverting the commit is the right thing to do. The current formula is incorrect. If we want to block panning of smaller images if their containing view is bigger then we should probably adjust getFixTrans() instead of setZoom().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants