Added Find Sibling MonoInstallers to all Contexts. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checked, the context will automatically get and install all monoinstallers attached to the context's gameobject. This is important for when the context is used with prefab variants.
Mathijs-Bakker
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version you have to manually specify installers that you want to have run on a specific context in a list. This doesn't work very well with prefab variants.
For example, If you have prefab "Base" and prefab "Variant", If you modify the installer list on "Variant", the whole list will be marked as overridden. As a result, if you add any new installer to installer list in "Base", they will not automatically be added to the list of installers in "Variant". You have to go through all variants and add the installer manually.
With this change, you no longer need to change the installer list. Each installer will get all attached MonoInstallers automatically.
Is this a breaking change? No, this feature is opt-in.