Add K8800 board entry to the boards.h file #19331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the numbers are moved around to keep the list nice and tidy. The pins file and everything else is already there.
riodoro1
force-pushed
the
add-k8800-to-boards
branch
from
b8a3dd5 to
01a4101
Compare
|
Thanks for the patch! I'm not sure how that one got lost in the mix. |
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
kageurufu
pushed a commit
to CR30-Users/Marlin-CR30
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add K8800 (Velleman Vertex Delta) controller to the
boards.hfile.The board has its respective
pins_K8800.hfile which is properly included inpins.h.All of the siblings of the Vertex Delta (K8200, K8400, K8600) are already in
boards.hso it seems this is a slip of hand while writing the file.The board is sadly almost at the top of the list so the numbers need to be changed for most boards.
If you think this part is going to cause problems maybe I should add this entry at the end, this would hovewer be less nice.
Benefits
"Completeness" of the file and gives me less effort to prepare my own branch which supports this printer fully.
I want to be able to have this branch easily updatable and the boards file would be one less hassle.
Configurations
not applicable
Related Issues
I didn't create a FR for this.