Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix M166 Gradient Mix on delta printers #19283

Closed
wants to merge 1 commit into from
Closed

Fix M166 Gradient Mix on delta printers #19283

wants to merge 1 commit into from

Conversation

Kadah
Copy link
Contributor

@Kadah Kadah commented Sep 7, 2020

Description

The updates for M166 gradient mix on delta printers use the z tower stepper position instead of the toolhead cartesian z position. This leads to current gradient mix being constantly changing during a single layer as seen here and results in the gradient being rotated and offset.

Example:

2020-09-06 12 34 46

I am not sure if the fix I have made is the correct way to do it. I have been running with this patch and it does fix the issue. This likely creates additional cycles with having to call for a forward kinematics update more often, though a delta+mixing setup should already preclude 8-bit controllers.

Benefits

Allows M166 to work as intended on delta printers.

Configurations

RGB_Delta.zip

Related Issues

#18917

@Kadah
Copy link
Contributor Author

Kadah commented Sep 7, 2020

Workflow failed due to error when trying to comment and close this for release target. Closing.

@Kadah Kadah closed this Sep 7, 2020
@thisiskeithb
Copy link
Member

delta+mixing setup should already preclude 8-bit controllers.

If you wanted to be extra cautious, you could add a sanity check to warn AVR users that a delta + mixing is ill-advised.

@Kadah
Copy link
Contributor Author

Kadah commented Sep 7, 2020

Corrected RP #19285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants