Make small segment handling in JD configurable #18316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The curvature-based handling of small segments creates problems, in case the slicer does not perfectly distribute all junction angles. This change makes the handling user-selectable.
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The curvature-based handling of small segments (<1 mm, > 135°) creates problems, in case the slicer does not perfectly distribute all junction angles ([1]). This change makes the handling user-selectable.
On the one hand, it's a quick workaround until major changes in the planner are introduced to fix the underlying issue. On the other hand, it's - in my opinion - a useful config switch, even after such a fix will be implemented.
Benefits
Related Issues
#17342, #17920, probably others I don't know about.