Refactor SD detect handler #17380
Merged
Refactor SD detect handler #17380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bf2_refactor_sd_detect_PR
branch
8 times, most recently
from
ac52480 to
32b4240
Compare
Co-Authored-By: Eric Ptak <[email protected]>
thinkyhead
force-pushed
the
bf2_refactor_sd_detect_PR
branch
from
32b4240 to
10149c1
Compare
|
That remove the "Printer Ready" message on the LCD, replaced by "Media inserted" |
|
Thanks! I didn't notice due to testing |
|
P.S. What kind of LCD? (ExtUI is affected differently from HD44780.) |
|
I've patched Marlin so ExtUI won't show the "inserted" message when the status changes from 'unknown' to mounted. That should do the trick. |
DerAndere1
pushed a commit
to DerAndere1/Marlin
that referenced
this pull request
Apr 9, 2020
Co-Authored-By: Eric Ptak <[email protected]>
ghost
pushed a commit
to bfhobbes/Marlin
that referenced
this pull request
Apr 15, 2020
Co-Authored-By: Eric Ptak <[email protected]>
mathom
pushed a commit
to mathom/Marlin
that referenced
this pull request
Apr 17, 2020
Co-Authored-By: Eric Ptak <[email protected]>
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
Co-Authored-By: Eric Ptak <[email protected]>
njibhu
pushed a commit
to njibhu/Marlin
that referenced
this pull request
Aug 24, 2020
Co-Authored-By: Eric Ptak <[email protected]>
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Co-Authored-By: Eric Ptak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: SD card detection is handled in the LCD or ExtUI update which means isolated SD card readers don't get auto-mounted unless there is a controller. Also, if both UltraLCD and ExtUI LCD controllers are connected, both of them do SD detection and this may be potentially conflicting.
Solution: This PR moves SD card detection to the
CardReaderclass and UI response to SD events to a separateMarlinUImethod (instead of doing this inMarlinUI::update).