Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearange UI elements and make categories expandable #477

Open
wants to merge 61 commits into
base: main
Choose a base branch
from

Conversation

matbmapspeople
Copy link
Contributor

@matbmapspeople matbmapspeople commented Feb 26, 2025

What?

The first scope of this merge request is to shuffle around the UI elements - also based on device that is using Web App. Figma design link: https://www.figma.com/design/y2Bq918f4KKMpIIY7ibSkE/MapTemplate?node-id=4120-2606

The second scope of this merge request is to remove horizontal categories and make them vertical. Then after clicking one of them we should have a list of Locations that have this category assigned.

How?

For the categories part

Inside Categories.jsx:

  • I removed all the code related to horizontal scrolling: buttons disabled states, updateScrollButtonsState function and disabled state listeners.
  • Instead, I added a custom made div that consists category img and displayName.

Inside Categories.scss:

  • I added all relevant styling to match Figma design.

Inside Search.jsx:

  • I added logic to listen for clicks outside the search input field to toggle categories list.

Inside Search.scss:

  • I added relevant styling for back button.

For the UI shuffling part:

  • Repositioned zoom control
  • Added desktop specific styling for:
    • ViewMode switch
    • Venue Selector
  • Handled desktop styling for office demo

Lucaci-Andrei and others added 30 commits February 19, 2025 14:14
…-right controls in MapboxMap.scss for desktop mode
Reposition zoom control and adjust margin in MapboxMap component
…__expandable_categories

Refactor/rearange UI elements  expandable categories
…'origin' into refactor/move-venue-selector-and-2d-switch
@matbmapspeople
Copy link
Contributor Author

I tried to resolve all the comments @ammapspeople. It's ready for re-review.

@ammapspeople
Copy link
Collaborator

  1. How come the back button texts are different from the category name?
Kapture.2025-03-11.at.15.39.41.mp4
  1. Since categories don't show up at all on smaller screens, should this pull request point towards a feature branch instead of main?

@matbmapspeople
Copy link
Contributor Author

matbmapspeople commented Mar 12, 2025

  1. How come the back button texts are different from the category name?

Kapture.2025-03-11.at.15.39.41.mp4
2. Since categories don't show up at all on smaller screens, should this pull request point towards a feature branch instead of main?

Fixed categories and back button name 😄 @ammapspeople

@matbmapspeople
Copy link
Contributor Author

We've addressed all the comments now @ammapspeople 😄

Copy link
Collaborator

@ammapspeople ammapspeople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one small suggestion 🏁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants