Add /plot teleport [plot] command #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to teleport to an arbitrary plot by its x,z "id" This change also adds a new completion parser, "Greedy", which corresponds to `brigadier:string` with flags indicating that it accepts anything from the argument to the end of the line. This is necessary because the plot id doesn't seem to be anything Minecraft can parse by itself, and is you use `brigadier:string` in "one word" mode, the parser believes the argument ends at the comma and shows an error for valid input. I use the "x,z" format to match plotsquared's command API, but if people don't like that it's easy enough to swap out for seperate arguments.
|
I think it would be better to do |
Removes Greedy (no longer necessary) Removes Plot::parse_id (no longer used) Adds brigadier::vec2 for 2d position
|
Updated to swap over to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to teleport to an arbitrary plot by its x,z "id"
This change also adds a new completion parser, "Greedy", which
corresponds to
brigadier:stringwith flags indicating that it acceptsanything from the argument to the end of the line. This is necessary
because the plot id doesn't seem to be anything Minecraft can parse by
itself, and is you use
brigadier:stringin "one word" mode, the parserbelieves the argument ends at the comma and shows an error for valid
input.
I use the "x,z" format to match plotsquared's command API, but if people
don't like that it's easy enough to swap out for separate arguments.
I mostly wanted to move
parse_idout into a separate function becausewithout access to
?parsing that was starting to get ugly.