Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize YouTube links #101

Closed
Lurk opened this issue Sep 23, 2023 · 2 comments
Closed

Sanitize YouTube links #101

Lurk opened this issue Sep 23, 2023 · 2 comments

Comments

@Lurk
Copy link
Owner

Lurk commented Sep 23, 2023

image

Credit:
https://anticapitalist.party/@kropot/111099960211372703

@0x61nas
Copy link
Contributor

0x61nas commented Sep 26, 2023

The reason that makes us unable to write a pattern for it in the exit array is the changeable video ID, right?

@Lurk
Copy link
Owner Author

Lurk commented Sep 27, 2023

@0x61nas no. Exit vec is for unwrapping exit URLs.

For example: https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=&cad=rja&uact=8&ved=2ahUKEwjMuu2zrreBAxUt2gIHHaDVC_gQyCl6BAgqEAM&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DdQw4w9WgXcQ&usg=AOvVaw0aHtehaphMhOCAkCydRLZU&opi=89978449

Will be unwrapped to: https://www.youtube.com/watch?v=dQw4w9WgXcQ

What we want to achieve in this issue is that the 'remove' mode will remove the si query param but only if the host is youtube.com. I am not sure that we can just add si to ClinkConfig.params because maybe, in some cases (not YouTube), it is legitimate query param.

bershadskiy pushed a commit to bershadskiy/clink that referenced this issue May 12, 2024
Lurk#101

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
config is extended with a custome patter for a domain specific fields
the pattern lokos like "{}``{}",domain,param
Lurk added a commit that referenced this issue May 14, 2024

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
@Lurk Lurk closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants