Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate namespace-lmms changes into Zyn submodule. #18

Merged
merged 3 commits into from
Jun 19, 2022
Merged

Integrate namespace-lmms changes into Zyn submodule. #18

merged 3 commits into from
Jun 19, 2022

Conversation

irrenhaus3
Copy link
Contributor

Adds lmms:: namespace prefix to symbols in the namespace as implemented in main repo PR #6174 https://github.com/LMMS/lmms/pull/6174.
To be merged after 6174 is in master.

@irrenhaus3 irrenhaus3 marked this pull request as ready for review April 24, 2022 14:55
@irrenhaus3 irrenhaus3 mentioned this pull request Jun 11, 2022
Merged
JohannesLorenz
JohannesLorenz approved these changes Jun 18, 2022
View reviewed changes
Copy link
Contributor

@JohannesLorenz JohannesLorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that one was smaller than I expected. Only 4 lines changed...

allejok96
allejok96 approved these changes Jun 19, 2022
View reviewed changes
Copy link

@allejok96 allejok96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing special here, looks good and compiles on Linux. I don't see any other includes of lmms headers in Zyn or ifdefs that could cause a problem.

@JohannesLorenz JohannesLorenz merged commit b9855db into LMMS:master Jun 19, 2022
@irrenhaus3 irrenhaus3 deleted the namespace-lmms branch June 19, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesLorenz JohannesLorenz JohannesLorenz approved these changes

@allejok96 allejok96 allejok96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irrenhaus3 @JohannesLorenz @allejok96