Rework Crossover EQ plugin GUI

[rubiefawn]

Replaces the .png raster assets for the native Crossover EQ plugin with .svg vector assets. Additionally, this PR reworks the entire layout of the Crossover EQ since it was kind of busted. Now it looks better, stuff no longer overlaps, and it uses the new mute buttons.

Note

Part of #7767

[rubiefawn]

I appear to have reverted my changes to the wrong file, so now instead of a layout refactor this PR is just an extra newline on an unrelated file. 🤦‍♀️ I'll mark this as ready once I redo it, I guess

[rubiefawn]

Crossover EQ still does not display the loudness of the bands. I'd like to do that and also add sample-exactness to the controls (so they can be automated without tons of crackling) in a separate PR. This PR can just focus on fixing the GUI layout.

[regulus79]

I have not reviewed the code, but I tested it and it appears to work and look fine.

[tresf]

This is fantastic work. As mentioned here #7767 (comment) I'd like to see the QPixmap workarounds moved to a shared location prior to merging if possible.

[tresf]

This is fantastic work. As mentioned here #7767 (comment) I'd like to see the QPixmap workarounds moved to a shared location prior to merging if possible.

After following my own advice and attempting this, I came across some technical challenges. In short, to avoid unnecessary complexity and computation, the size really does belong in the constructor.

That's not to say we can't simplify this a bit still. Here's a diff that would move the computation to a helper, which I think is the best we can do without drawbacks.

crossover_eq_logicalSize.diff.txt

Click to preview diff

diff --git a/include/embed.h b/include/embed.h
index 40a3622c6..1ddcdbefa 100644
--- a/include/embed.h

+++ b/include/embed.h
@@ -51,6 +51,20 @@ auto LMMS_EXPORT getIconPixmap(std::string_view name,
 	int width = -1, int height = -1, const char* const* xpm = nullptr) -> QPixmap;
 auto LMMS_EXPORT getText(std::string_view name) -> QString;
 
+/**
+ * @brief logicalSize is a backwards-compatible adapter for
+ * QPixmap::deviceIndependentSize.
+ * @param pixmap The pixmap to get the size of.
+ * @return The device-independent size of the pixmap.
+ */
+inline auto LMMS_EXPORT logicalSize(const QPixmap& pixmap) {
+#if QT_VERSION >= QT_VERSION_CHECK(6, 2, 0)
+    return pixmap.deviceIndependentSize().toSize();
+#else
+    return pixmap.isNull() ? QSize() : pixmap.size() / pixmap.devicePixelRatio();
+#endif
+}
+
 } // namespace embed
 
 class PixmapLoader
diff --git a/src/gui/widgets/Fader.cpp b/src/gui/widgets/Fader.cpp
index a1324016e..c8c240e9a 100644
--- a/src/gui/widgets/Fader.cpp
+++ b/src/gui/widgets/Fader.cpp
@@ -73,7 +73,7 @@ SimpleTextFloat* Fader::s_textFloat = nullptr;
 Fader::Fader(FloatModel* model, const QString& name, QWidget* parent, bool modelIsLinear) :
 	QWidget(parent),
 	FloatModelView(model, this),
-	m_knobSize(m_knob.size() / m_knob.devicePixelRatio()),
+	m_knobSize(embed::logicalSize(m_knob)),
 	m_modelIsLinear(modelIsLinear)
 {
 	if (s_textFloat == nullptr)
diff --git a/src/gui/widgets/PixmapButton.cpp b/src/gui/widgets/PixmapButton.cpp
index bd683ed71..5858f3b8c 100644
--- a/src/gui/widgets/PixmapButton.cpp
+++ b/src/gui/widgets/PixmapButton.cpp
@@ -107,7 +107,7 @@ void PixmapButton::mouseDoubleClickEvent( QMouseEvent * _me )
 void PixmapButton::setActiveGraphic( const QPixmap & _pm )
 {
 	m_activePixmap = _pm;
-	resize(m_activePixmap.size() / m_activePixmap.devicePixelRatio());
+	resize(embed::logicalSize(m_activePixmap));
 }
 
 
@@ -129,9 +129,7 @@ QSize PixmapButton::sizeHint() const
 
 QSize PixmapButton::minimumSizeHint() const
 {
-	const auto activeSize = m_activePixmap.size() / m_activePixmap.devicePixelRatio();
-	const auto inactiveSize = m_inactivePixmap.size() / m_inactivePixmap.devicePixelRatio();
-	return activeSize.expandedTo(inactiveSize);
+	return embed::logicalSize(m_activePixmap).expandedTo(embed::logicalSize(m_inactivePixmap));
 }
 
 bool PixmapButton::isActive() const

[rubiefawn]

I've added the helper function as requested, with the caveat that it will show deprecation warnings when being compiled with Qt versions >= 6.2, since QPixmap::deviceIndependentSize() is available. Ideally this helper function should be removed once it's no longer needed.

[tresf]

I've added the helper function as requested, with the caveat that it will show deprecation warnings when being compiled with Qt versions >= 6.2, since QPixmap::deviceIndependentSize() is available. Ideally this helper function should be removed once it's no longer needed.

Thanks!

[tresf]

Tested saving a Crossover EQ from previous versions of LMMS and reloading , no regressions found. Due to the number of lines changed, I think a code review should be done as well.

[bratpeki]

Lovely PR! Taking a look now.

[bratpeki]

Tested visually and with some white noise and a spectrum analyzer, and it's still functioning. LGTM!

[tresf]

I've reviewed the code. The lambdas look much cleaner and reduce code duplication. The only thing that stands out is that some translation strings will have to be updated since the help text has been slightly changed.

I've also noticed that the plugin uses both "gain" and "volume" to describe the DBFS, which seems like a bit of bitrot, but the "Volume" label wasn't touched in this refactor, so I'm fine leaving it as-is.