Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RealtimeSanitizer to the CMake build system #7764

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add RealtimeSanitizer to the CMake build system #7764

wants to merge 18 commits into from

Conversation

sakertooth
Copy link
Contributor

See title. More info on this code sanitizer and how to use it can be found here.

@sakertooth sakertooth marked this pull request as draft March 11, 2025 10:53
@sakertooth sakertooth marked this pull request as ready for review March 13, 2025 20:33
messmerd
messmerd reviewed Mar 14, 2025
View reviewed changes
@sakertooth sakertooth added the needs testing This pull request needs more testing label Mar 15, 2025
@sakertooth
Apply suggestions from messmerd and some more
de6b38c
@sakertooth
Add noexcept along with LMMS_NONBLOCKING
7a4b0d3 
Clang gives a warning (-Wperf-constraint-implies-noexcept) if noexcept is not added along with attributes like [[clang::nonblocking]]
@JohannesLorenz JohannesLorenz changed the title Add RealtimeSantizer to the CMake build system Add RealtimeSanitizer to the CMake build system Mar 16, 2025
@JohannesLorenz JohannesLorenz self-requested a review March 16, 2025 18:17
JohannesLorenz
JohannesLorenz approved these changes Mar 16, 2025
View reviewed changes
Copy link
Contributor

@JohannesLorenz JohannesLorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generally good.

Of course, this cannot fix the 1000s of expected findings and thus cannot add a CI.

Reminder that it might make sense to update the wiki (and then, maybe update submodule doc/wiki inside this PR?)

@sakertooth
Copy link
Contributor Author

CI broke. Apparently you can't update the wiki directly within the PR, so I'll stash my recent changes and apply them to the wiki after merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messmerd messmerd messmerd left review comments

@JohannesLorenz JohannesLorenz JohannesLorenz approved these changes

Assignees
No one assigned
Labels
needs testing This pull request needs more testing
Projects
Make LMMS realtime safe
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sakertooth @JohannesLorenz @messmerd