-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make portsmf a git submodule #7755
base: master
Are you sure you want to change the base?
Conversation
Marking this as a draft while I test MIDI import for regressions. I have no idea what version of portsmf was previously being used vs whatever the current version is, so it could be completely broken for all I know. |
This is a hack and should be removed as soon as upstream portsmf fixes their stuff
Here's the diff. Here's the commit history in LMMS:
The diff is probably enough to hand-patch and provide it upstream, however in doing so, it would probably make sense to do it for the entire project (not just the files we use from it). When working on #3963, we had to do this for |
It looks like my initial PR for upstream that fixes the compiler warnings got merged, so that's nice! I'll update the submodule. |
I'm going to temporarily point the submodule at my fork while I fix all this, and then make a PR against upstream once it's compiling fine in here |
Why is it being treated as anything else but a diagnostic string? The preprocessor is an evil contraption I will never fully understand. Who invented this smh
Also remove an unused variable
I'll need to confirm with the maintainer of portsmf what C++ standard the library targets. A lot of these changes (and a lot of the changes I have made myself) are dependent on at least C++11. Upstream's decision there will determine how much of that I can keep. |
This makes portsmf, which is used in the MIDI import plugin, a git submodule.