Migrate CI to GitHub Actions #6476
Conversation
It takes up about 40% of the total cache quota. We should investigate shrinking it, and have it depend on a list of dependencies so we don't have to cache it anew each time.
Turns out it never worked in the first place. Can be added later with some additional effort.
There was a problem hiding this comment.
Only 2 minor comments.
Main issues:
You're using artifacts, but in your action tab, I can't find out how to download them-> I was too dumb to scroll down 😁- The LMMS bot did not run for this PR. Can we somehow verify that it's still working?
The host version doesn't matter since we're using Docker, so use something we won't have to update manually.
Ninja should be able to determine this automatically.
It only works for CircleCI and AppVeyor builds, and I removed the configuration files for those in this PR. In order to download artifacts from GitHub Actions, you need to be logged into GitHub, so posting raw links to artifacts won't work. However there are third-party services that can provide download links, such as nightly.link. The bot could be changed to link to that site, or as a temporary replacement, https://github.com/oprypin/nightly.link/blob/master/.github/workflows/pr-comment.yml might be worth trying. Eventually I think it would be nice to provide nightly and PR downloads via lmms.io, but that's getting more and more out of scope. |
|
I've been receiving random emails about failed builds from AppVeyor & CircleCI for years now with no way to turn them off. Finally those days are over. Thank you @DomClark 🙏 |
Every time some issue comes up with CI, moving to GitHub Actions is brought up. Well, here we go.