clang-tidy: Apply modernize-use-using everywhere #6453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missed some. Going hunting. |
+ Fix audioMasterCallback using declaration in aeffectx.h
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://output.circle-artifacts.com/output/job/8b6dd84c-8bbc-4bfe-8e4c-ce5512e308be/artifacts/0/lmms-1.3.0-alpha.1.224+g0012adf7b-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/354?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/c106e084-dbbd-4143-b193-842c0d31771c/artifacts/0/lmms-1.3.0-alpha.1.224+g0012adf7b-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/355?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/656786f7-4487-4f21-a484-17ab3580fae5/artifacts/0/lmms-1.3.0-alpha.1.224+g0012adf7b-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/353?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/2619dnpk8w1tmdki/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/44099369"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/i0l9icgi1iq4hbg1/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/44099369"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://output.circle-artifacts.com/output/job/1552d590-622d-4e5c-a9e5-fec8cf6f74ea/artifacts/0/lmms-1.3.0-alpha.1.224+g0012adf7b-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/351?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "0012adf7b5a74ae78f8f0583b9e99a35ef014942"} |
…s/LadspaEffect/LadspaEffect.h
…aration. + Change alias declaration in LadspaEffect.h to using PortDescription = struct port_desc_t.
+ Replace new PortDescription with new port_desc_t in LadspaEffect.cpp.
JohannesLorenz
approved these changes
Jun 30, 2022
PhysSong
reviewed
Jul 7, 2022
PhysSong
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clang-tidy check converts
typedefdeclarations into theirusingdeclaration equivalent. This PR in particular also updates C-style typedef arrays withstd::array. Do note that it may seem possible to replace some typedef function pointers withstd::functionat first. However, this created problems with the surrounding codebase, so those declarations are left as function pointers.