Remove QVector from core

[Veratil]

Removes [almost all] QVector from src/core/.

Only thing left is to change InstrumentFunctionNoteStacking::ChordTable. This will most likely require a bit more than changing QVector to std::vector since ChordTable inherits QVector and we don't want to inherit std::vector.

After changing a file I'd recompile lmms and open multiple demos and play them all to give a "working" test. No crashes. 👍

[sakertooth]

Shouldn't this be merged as its own commit in #6426?

[Veratil]

Shouldn't this be merged as its own commit in #6426?

It could! 😁

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

• Linux (AppImage): lmms-1.3.0-alpha.1.194+gbfd207645-linux-x86_64.AppImage (build link)

Windows

• Windows 32-bit: lmms-1.3.0-alpha.1.194+gbfd207645-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha.1.194+gbfd207645-mingw-win64.exe (build link)
• Windows 32-bit: lmms-1.3.0-alpha-msvc2017-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha-msvc2017-win64.exe (build link)

🤖

{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://output.circle-artifacts.com/output/job/da0546c7-6f20-4b77-819d-78f1daf84ef9/artifacts/0/lmms-1.3.0-alpha.1.194+gbfd207645-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17200?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/9b9ebf69-5d8d-4949-a20f-7612c021a5f3/artifacts/0/lmms-1.3.0-alpha.1.194+gbfd207645-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17199?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/2bdd498c-0922-43ac-bfc3-8c14fb5fd591/artifacts/0/lmms-1.3.0-alpha.1.194+gbfd207645-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17196?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/5e2kxp2xxd8n4o5e/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/43832301"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/0ps7lyiqtmqeh037/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/43832301"}]}, "commit_sha": "4f2a59a526b11a706b8abc65db3f3dcc8b0dd7e3"}