-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implementation of Vocal Synthesis in LMMS #5937
Draft
SeleDreams
wants to merge
7
commits into
LMMS:master
Choose a base branch
from
SeleDreams:vocal_synthesis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
macOS🤖{"platform_name_to_artifacts": {"macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12900-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.81%2Bg0355a0cfe-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12900?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "da9afe02a9b9775e48d7deb4ba1ca0f858948ac1"} |
huh seems like codefactor is still seeing issues that were fixed in my second commit, maybe the two commits close from each other was too much for it |
…calInstruments to generate a new VocalInstrumentTrack, and fixed a crash when a voicebank isn't loaded and the user tries to add lyrics to a vocal track
…nt back to single threading due the code not being thread-safe
…e automatic silence adding to the wavtool
f81a2ad
to
da9afe0
Compare
I'll probably end up fully rewriting it since the previous implementation was kind of hacky |
Last time I worked on openutau's source experimenting with vst support that
might be complicated. OpenUtau's rendering system was honestly pretty
messy. It might likely be actually easier to make a dedicated clap plugin
for utau voices.
Le mar. 25 févr. 2025 à 23:02, Dalton Messmer ***@***.***> a
écrit :
… If OpenUtau <https://github.com/stakira/OpenUtau> could be ported to a
CLAP plugin, and if LMMS gained support for per-note parameter automations
for CLAP plugins in a potential follow-up PR after #7199
<#7199> is merged, then that might be a
better way to do this.
—
Reply to this email directly, view it on GitHub
<#5937 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4UF4N73L7ATILTTMKEHLT2RTR6XAVCNFSM6AAAAABX3XNFHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBTGM4TIMRVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: messmerd]*messmerd* left a comment (LMMS/lmms#5937)
<#5937 (comment)>
If OpenUtau <https://github.com/stakira/OpenUtau> could be ported to a
CLAP plugin, and if LMMS gained support for per-note parameter automations
for CLAP plugins in a potential follow-up PR after #7199
<#7199> is merged, then that might be a
better way to do this.
—
Reply to this email directly, view it on GitHub
<#5937 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4UF4N73L7ATILTTMKEHLT2RTR6XAVCNFSM6AAAAABX3XNFHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBTGM4TIMRVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP pull request must not be merged yet.
I am working on implementing vocal synthesis support to LMMS, I was working at first on a kind of dirty branch where I did a lot of tests that kind of made everything a mess, I am now working on it in a cleaner manner where I am adding my features while keeping as much as possible intact and avoiding to include files that must not be included in the commits (such as voicebanks and build files)
Once the feature finished, here are various additional abilities LMMS will have :
This is the current status of the feature in this video (Some code isn't ported to the new branch yet, so just building the code currently in this PR won't achieve the same result)
https://youtu.be/YzU8DfbJJt8